zengm
zengm copied to clipboard
Enhancement - Ratings Popover on Hover+Focus
Rather than using click for a trigger, it would be nice to use
trigger={['hover', 'focus']}
in basketball-gm/src/js/ui/components/RatingsStatsPopover.js
or to have the option. I understand that hover focus isn't ideal for touch devices.
Maybe...
Anyone else have opinions?
I should say I tested it locally and liked it. I find that when I'm looking at stats for a player, I'm often looking at stats for a number of players consecutively, meaning that the faster I can get the popup to show the happier I am.
I've also tested reorganizing the statistics differently, with a column for 'big man' stats like height, and rebounding, and a 'little man' stats column for stats like 3pts, steals and passing. Segregating the stats that way makes it a lot easier to judge a player.
I also tried modifying the coloring instead of using a cutoff, to use a gradient scale using HSL and modifying the lightness of the Green of Red text. The result is more intuitive (and also looks a bit better on the dark background custom css that is popular).
Just some thoughts.