zend-mail icon indicating copy to clipboard operation
zend-mail copied to clipboard

remove Null Transport

Open samsonasik opened this issue 7 years ago • 6 comments

since composer.json master branch is only support php:^7.1

samsonasik avatar Mar 01 '18 21:03 samsonasik

Please rebase this against develop and change the target branch. Since it's a BC break, it needs to target a new major version.

weierophinney avatar Mar 01 '18 21:03 weierophinney

@weierophinney I've rebased against develop and change target to develop branch.

samsonasik avatar Mar 01 '18 21:03 samsonasik

i suppose it addresses problem that null is no longer allowed as class names in newer php versions?

and explanation why it's removed not just renamed?

also, fix spelling: Tranport -> Transport,

glensc avatar Mar 06 '18 15:03 glensc

the null transport was mapped to inMemory, so, it is same to use inMemory. Thank you, I've updated PR title Tranport -> Transport,

samsonasik avatar Mar 06 '18 21:03 samsonasik

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mail to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mail.
  • In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.

weierophinney avatar Dec 31 '19 21:12 weierophinney

This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at https://github.com/laminas/laminas-mail/issues/36.

michalbundyra avatar Jan 15 '20 19:01 michalbundyra