zend-mail icon indicating copy to clipboard operation
zend-mail copied to clipboard

Drop dependency on zendframework/zend-loader

Open acelaya opened this issue 7 years ago • 9 comments

This removes the dependency on the zendframework/zend-load package, as suggested in #185

The HeaderLoader class has been removed and replaced by a simple class map in the Headers class.

However, I have also removed the getPluginClassLoader and setPluginClassLoader methods. Since they are public, this might be a BC break. What do you think?

acelaya avatar Dec 21 '17 14:12 acelaya

Builds are failing with latest dependencies, but they are failing in master too.

I'll try to figure out how to fix them, but it might take me time.

acelaya avatar Dec 21 '17 15:12 acelaya

Please rebase onto develop

Xerkus avatar Dec 21 '17 15:12 Xerkus

There is a PR with fix, I will merge it shortly

Xerkus avatar Dec 21 '17 15:12 Xerkus

Perfect then. Thanks.

acelaya avatar Dec 21 '17 15:12 acelaya

I have rebased develop. I'll do it again once you merge the other PR.

acelaya avatar Dec 21 '17 15:12 acelaya

Just a heads up: there is a big ongoing effort going for next major versions for zend-expressive and related packages as well as for zend-mvc. This change will require a next major version, and I do not expect to get to it until february.

Xerkus avatar Dec 21 '17 15:12 Xerkus

Ok, no rush :-)

acelaya avatar Dec 21 '17 15:12 acelaya

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mail to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mail.
  • In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.

weierophinney avatar Dec 31 '19 21:12 weierophinney

This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at https://github.com/laminas/laminas-mail/issues/39.

michalbundyra avatar Jan 15 '20 19:01 michalbundyra