zend-inputfilter icon indicating copy to clipboard operation
zend-inputfilter copied to clipboard

Input Fallback Value is not merged on Input::merge()

Open Maks3w opened this issue 9 years ago • 4 comments

I think the fallback value should be replaced when merge is done.

Maks3w avatar Aug 22 '15 15:08 Maks3w

I think this is bug not a BC break. I don't think someone is relying on current behavior. But yes also it can be BC break, but very unlikely. This is not documented, no tests.. so I think we don't need to wait till 3.0

svycka avatar Aug 24 '15 13:08 svycka

Imho the intended behavior of merge is to also take care of the fallback value. Therefore this qualifies as a bugfix. I really would like to see this fixed asap.

        if ($input instanceof Input && $input->hasFallback()) {
            $this->setFallbackValue($input->getFallbackValue());
        }

ping @Maks3w

zluiten avatar Oct 02 '15 13:10 zluiten

Fallback feature and merge method exists since a long time and nobody appreciate this before. My conclusion any change in the current behavior introduces a BC break.

Maks3w avatar Oct 02 '15 13:10 Maks3w

This repository has been closed and moved to laminas/laminas-inputfilter; a new issue has been opened at https://github.com/laminas/laminas-inputfilter/issues/12.

weierophinney avatar Dec 31 '19 21:12 weierophinney