zend-filter icon indicating copy to clipboard operation
zend-filter copied to clipboard

Published 20 hours ago • verified publisher icon zendframework

PSR-7 file upload parameter naming consistency.

Open alextech opened this issue 6 years ago • 5 comments

  • [x] Is this related to quality assurance?
  • [x] Is this related to documentation? Upgrading my setup to released version of #70 caused some confusion. Updating parameter to help resolve it, and suggest a documentation edit to explain where the instances could come from, as I couldn't figure it out without looking at the diff changes of previous PR refactorings.

Add missing unit tests for new options.

alextech avatar Dec 19 '18 00:12 alextech

Thanks @froschdesign for review and catching same inconsistencies that tripped me up yesterday! Do you have a a hint on why 5.6 php travis is failing? I did not modify anything travis environment related to @weierophinney work, so would think it should work continuing from his setup.

alextech avatar Dec 19 '18 14:12 alextech

PSR-17, which is used via the package psr/http-factory, requires PHP 7. Mark those tests as requiring PHP 7 using @require PHP 7.

weierophinney avatar Dec 19 '18 15:12 weierophinney

@alextech As it is now it introduces BC Break. We can avoid it by deprecating previous keys and adding new. Also we need to keep old setter/getter (marked as deprecated) and proxy to new one.

michalbundyra avatar Aug 15 '19 16:08 michalbundyra

This repository has been closed and moved to laminas/laminas-filter; a new issue has been opened at https://github.com/laminas/laminas-filter/issues/3.

weierophinney avatar Dec 31 '19 22:12 weierophinney

This repository has been moved to laminas/laminas-filter. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-filter to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-filter.
  • In your clone of laminas/laminas-filter, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.

weierophinney avatar Dec 31 '19 22:12 weierophinney