zend-expressive-skeleton
zend-expressive-skeleton copied to clipboard
zendframework
Add case for 'Pimple\Psr11\Container' in HP
Hello @Ocramius @xtreamwayz,
I added a test case for the home-page response content (writing it made me also aware of another skipped case, namely the auryn wrapper). I have an issue with test with deps=lowest on travis: zend-servicemanager minimum version is 3.3. In that version the AbstractPluginManager only accepts a Interop\Container\ContainerInterface and not a Psr\Container\ContainerInterface. Any hint for solving this?
(*edited) ...or just skip other containers when using zend-view?
The @dataProvider for the test cases is similar to the ones I found in other test files: i create combination for 2 different install type [flat, modular] x all the supported containers x all the supported renderers x 1 router option (FastRoute) only.
The minimal install type is not tested, as that information is added to json responses in my next PR.
@Ocramius @xtreamwayz
Ok, skipping the zend-view / non zend-sm combinations solved it.
I was wondering if we could just use php imports and class constants like it's done for the router and the renderer and even if it would be worth parametrizing (container|router|template)(Name|Docs) by turning the HomePageHandler.php file into as an install resource itself.
This repository has been closed and moved to mezzio/mezzio-skeleton; a new issue has been opened at https://github.com/mezzio/mezzio-skeleton/issues/4.
This repository has been moved to mezzio/mezzio-skeleton. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
- Squash all commits in your branch (
git rebase -i origin/{branch}) - Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
- Run the laminas/laminas-migration tool on the code.
- Clone mezzio/mezzio-skeleton to another directory.
- Copy the files from the second bullet point to the clone of mezzio/mezzio-skeleton.
- In your clone of mezzio/mezzio-skeleton, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.