zend-eventmanager icon indicating copy to clipboard operation
zend-eventmanager copied to clipboard

Replace container-interop with PSR-11 container interface

Open michaelmoussa opened this issue 7 years ago • 4 comments

This PR replaces use of the container-interop package with the PSR-11 container interface. This is obviously a BC break and would need to be released in EventManager 4.0 along with a migration guide.

This PR is being submitted in conjunction with a similar PR on the zend-framework/zend-servicemanager repository. Before merging and releasing the zend-servicemanager PR, this one should be merged and released with a new major version, and the zend-servicemanager should have its Composer dependencies updated to include version 4.0 of zend-eventmanager.

michaelmoussa avatar Mar 28 '17 05:03 michaelmoussa

@weierophinney rebased this one w/changes from latest develop. The migration guide in this repo is organized differently from what I already did in ServiceManager... where would you like this part documented?

michaelmoussa avatar Dec 07 '17 15:12 michaelmoussa

Added a fix to the existing "Replace container-interop with PSR-11" commit for the failing tests.

michaelmoussa avatar Dec 07 '17 20:12 michaelmoussa

This repository has been closed and moved to laminas/laminas-eventmanager; a new issue has been opened at https://github.com/laminas/laminas-eventmanager/issues/5.

weierophinney avatar Dec 31 '19 21:12 weierophinney

This repository has been moved to laminas/laminas-eventmanager. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-eventmanager to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-eventmanager.
  • In your clone of laminas/laminas-eventmanager, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.

weierophinney avatar Dec 31 '19 21:12 weierophinney