zend-diactoros icon indicating copy to clipboard operation
zend-diactoros copied to clipboard

Published 20 hours ago • verified publisher icon zendframework

Hack Typechecker definitions needed

Open barbu110 opened this issue 9 years ago • 5 comments

Hi!

This module is excellent, but in a strict Hack project, is has no use, unfortunately, because of the lack of typechecker definitions.

Me and, for sure, many others, would appreciate if you wrote typechecker definitions!

barbu110 avatar Jun 04 '16 14:06 barbu110

Would you be willing to provide a patch with them, please?

weierophinney avatar Jun 04 '16 14:06 weierophinney

I am working on something, but I do not have time to finish them very soon.

barbu110 avatar Jun 04 '16 14:06 barbu110

@barbu110 What's the problem in a strict typed PHP 7 project?

sandrokeil avatar Jun 04 '16 14:06 sandrokeil

@sandrokeil, not PHP 7, Hack. The HHVM typechecker won't recognize the code of the module because it written in <?php, not <?hh, so .hhi definitions must be provided.

barbu110 avatar Jun 04 '16 14:06 barbu110

This repository has been closed and moved to laminas/laminas-diactoros; a new issue has been opened at https://github.com/laminas/laminas-diactoros/issues/21.

weierophinney avatar Dec 31 '19 22:12 weierophinney