zend-db icon indicating copy to clipboard operation
zend-db copied to clipboard

1. add return statement to Adapter::getHelpers method;

Open darluc opened this issue 6 years ago • 4 comments

Class Zend\Db\Adapter\Adapter method getHelpers, you guys forget to return the $functions

  • [x] Are you fixing a bug?
    • [ ] Detail how the bug is invoked currently.
    • [x] Detail the original, incorrect behavior.
    • [ ] Detail the new, expected behavior.
    • [ ] Base your feature on the master branch, and submit against that branch.
    • [ ] Add a regression test that demonstrates the bug, and proves the fix.
    • [ ] Add a CHANGELOG.md entry for the fix.

darluc avatar Jun 08 '18 08:06 darluc

@darluc you should probably provide a unit test that reproduces the bug as well.

malukenho avatar Jun 08 '18 14:06 malukenho

@malukenho okay, I'll try.

darluc avatar Jun 09 '18 08:06 darluc

This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-db to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-db.
  • In your clone of laminas/laminas-db, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.

weierophinney avatar Dec 31 '19 22:12 weierophinney

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at https://github.com/laminas/laminas-db/issues/49.

michalbundyra avatar Jan 16 '20 19:01 michalbundyra