zend-db icon indicating copy to clipboard operation
zend-db copied to clipboard

Allow invokable classes as predicate (solves #270)

Open heyphilllie opened this issue 7 years ago • 6 comments

This PR solves #270 . Predicates can now created from an invokable class. Like closures, the new predicates should directly added to the Select, Where or Update instance.

heyphilllie avatar Oct 10 '17 17:10 heyphilllie

@Ocramius the status of this one is hard... do we have someone willing to update this library for PHP 7? Or at a minimum get the travis and composer config moving in the right direction?

mwillbanks avatar Oct 20 '17 02:10 mwillbanks

IMO we should hold back new features until 7.1 is the minimum version. Everything we add without explicit type declarations will just come back like a boomerang.

Ocramius avatar Oct 20 '17 02:10 Ocramius

@Ocramius I tagged this as 3.0 release.

ezimuel avatar Nov 23 '17 13:11 ezimuel

@Ocramius I was wondering if you could go into detail how explicit type declarations would help in this situation or conversely if there is any foreseeable boomerang?

baileylo avatar Feb 05 '18 19:02 baileylo

This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-db to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-db.
  • In your clone of laminas/laminas-db, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.

weierophinney avatar Dec 31 '19 22:12 weierophinney

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at https://github.com/laminas/laminas-db/issues/62.

michalbundyra avatar Jan 16 '20 19:01 michalbundyra