zendesk_api_client_rb icon indicating copy to clipboard operation
zendesk_api_client_rb copied to clipboard

Published 20 hours ago • verified publisher icon zendesk

Fix faraday deprecation errors for `authorization`

Open arashm opened this issue 2 years ago • 2 comments

Fixes the deprecation errors:

WARNING: `Faraday::Connection#authorization` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:authorization, ...)` instead.

I couldn't directly use the client in the test since faraday only edits the headers somewhere using the middleware. So I had to make a request and check the request_header there.

arashm avatar May 16 '22 21:05 arashm

Is there a chance this gets a review? The deprecation messages this causes in our tests are a bit annoying. Thanks

arashm avatar Jun 20 '22 15:06 arashm

is this gem under active development? this is the second thread/PR/issue about faraday with just zero response from anyone official.

rsl avatar Aug 11 '22 13:08 rsl

FYI: We are working on releasing v2 of the gem that will support Faraday v2.

ecoologic avatar Sep 01 '22 22:09 ecoologic

Can this get merged before that?

arashm avatar Sep 01 '22 22:09 arashm

You're right@arashm, it would be better. I'll see with the team. 👍

ecoologic avatar Sep 05 '22 04:09 ecoologic