Support Faraday 2.x

[tmimura39]

Faraday 2.x has been released.

but, faraday is require to < 2.0.0 in the gemspec of zendesk_api. https://github.com/zendesk/zendesk_api_client_rb/blob/8665b8e9bfb638805be550ab54aca0ac59b86271/zendesk_api.gemspec#L29

Is it possible to relax the dependency?

[jrmhaig]

There are breaking changes so simply relaxing the dependency is not enough.

• The dependency method has been removed. This is used in lib/zendesk_api/middleware/request/encode_json.rb.
• Faraday::Response::Middleware has been removed. This is used in various places.
• Possibly various other changes too. See the upgrading guide.

[rsl]

so is the plan to just never upgrade? that really hurts those developers who want to keep their software up-to-date. that reply seems a little "not our problem/not planning to address it/old versions work for us".

update: seems like that's not the official reply. but a lack of official reply is just as horrible. :/

[jrmhaig]

@rsl I absolutely agree and yes, my reply was not an official reply. I was hoping that I had provided enough information so that the Zendesk developers could work on it and am a bit disappointed to not even have received an acknowledgement. I did start creating a fix myself but when I saw that it was more than a few minutes, and we are paying Zendesk for their service, I would really want paying for my time!

We are using Faraday elsewhere in our app and I would like to upgrade those parts to version 2 so this issue is a blocker for me.

[rsl]

yeh sadly, we're/i'm looking at ditching this gem [i've ran into other issues besides this] and making our own light wrapper around their REST API. i don't expect them to look into this. i forked the gem and looked at making the changes to make a PR [like a good OSS citizen] but man, those changes are VERY out of my league in terms of knowing how to change out the middleware approaches and things.

i couldn't even get the specs to run out of the box with that json change about dependency.

[ecoologic]

Hi there,

This update is not a trivial change, but we are likely to pick this up soon. We could surely have done a better job at keeping you informed and we hope to do a better job from now on.

[rsl]

oh yeah. i tried looking into it [i've contributed to other OSS projects] and unfortunately the changes in the Faraday internals [as well as just lower-level HTTP in general] were definitely daunting and caused me to back away.

[rsl]

that PR is looking good. just wanted to give some encouragement.

[ecoologic]

🎉 Good news! There's a release candidate version now available v1.38.rc1 that supports Faraday 2.

Please take a look and give us feedback, we'll do our best to be present and correct any problem with it. ❤️

[LandonSchropp]

@ecoologic Any chance there'll be a full release for this sometime soon?