sunshine-conversations-ios icon indicating copy to clipboard operation
sunshine-conversations-ios copied to clipboard

Xcode warnings

Open via-guy opened this issue 10 months ago • 1 comments

I'm submitting a ...

  • [x] bug report

Current Behaviour Compilation warnings are thrown for documentation:

SKTConversation.h In protocol SKTConversationDelegate for function conversationListDidRefresh: the @param value uses the type and not the name.

Smooch.h The functions startConversationWithCompletionHandler: and handleUserNotificationActionWithIdentifier: contain the error:

Declaration is marked with '@deprecated' command but does not have a deprecation attribute

You need to add something like __attribute__((deprecated("use <some other function> instead"))); to the function definitions.

Expected Behavior No warnings should be thrown.

Steps to Reproduce Add the Smooch library as a dependency to an app through Swift Package Manager in Xcode 15 and compile.

Environment Please let us know the following details about the environment in which you encountered this issue, as well as any other relevant information.

  • SDK version: 12.2.0
  • OS version: macOS 14.4.1, building for iOS 17.4
  • Device type: iOS
  • Integration type: SPM

via-guy avatar Apr 04 '24 09:04 via-guy