samson icon indicating copy to clipboard operation
samson copied to clipboard

Changeset should bust cache for all branch names

Open sandlerr opened this issue 10 years ago • 2 comments

Tags and commit hashes should be stable but branch tips are not. At the moment we only bust for master thanks to https://github.com/zendesk/samson/pull/511.

sandlerr avatar Jul 13 '15 01:07 sandlerr

@sandlerr @grosser Do you guy think it's good if we git branch on local cached repo to see if the entered reference is a branch? This may helps us busting cache. Though I think that in practice prolly master is only thing that we care about.

I can put up a PR for this.

v9n avatar Jul 13 '15 23:07 v9n

I think we opted to make it simple to reduce the number of api requests ... ideally we would get the sha and then cache on that without having to do api request ... but the we have to fetch the repo first :(

maybe we can hand the deploy object into the method and cache based on it ?

grosser avatar Jul 14 '15 00:07 grosser