basecrm-ruby icon indicating copy to clipboard operation
basecrm-ruby copied to clipboard

The documentation of this gem is troubling

Open Nowaker opened this issue 9 years ago • 2 comments

Pretty simple code: @base.deals.create name: lead.email, contact_id: contact.id, stage_id: stage_id, tags_joined_by_comma: 'vk-onboarding'

There's absolutely no documentation on how to add tags to deal, leads and contacts. I found tags_joined_by_comma in one of the tickets. I found tag_list in a different one. None of this works.

The documentation of this gem is troubling. Also, I can pass any garbage (e.g. tag_list which doesn't look to be supported) and that field is silently ignored. The API should throw an exception when an unmatched parameter is found (if you use Rails on the backend, it'd be config.action_controller.action_on_unpermitted_parameters = :raise).

Nowaker avatar Jan 12 '16 00:01 Nowaker

Hi @Nowaker,

what version of the official client library do you use ? Once you have a client instantiated it's as simple as calling:

client.deals.create(contact_id: test_contact.id,
                    name: "test deal",
                    value: 100,
                    currency: "USD",
                    tags: ["test_1", "test_2"])

iaintshine avatar Feb 25 '16 20:02 iaintshine

I've changed a title of this issue to drag your focus to the real problem. Stripe API gem is a perfection, this one is just the opposite.

Nowaker avatar Feb 26 '16 00:02 Nowaker