app_scaffold icon indicating copy to clipboard operation
app_scaffold copied to clipboard

Generated rollup\translations-loader-plugin.js not friendly to Windows developers

Open mpowa705 opened this issue 5 months ago • 1 comments

The generated line in rollup\translations-loader-plugin.js

if (id.endsWith('.json') && id.includes(path.resolve(__dirname, '../src/translations'))) {

Does not work on Windows due to '/' in the id vs. the '\' in the __dirname on that system.

Changing this to:

id.endsWith('.json') && path.normalize(id).includes(path.resolve(__dirname, '..', 'src', 'translations'))

Resolves the issue on my Windows machine.

This should be changed in the webpack.config.js to ensure this works for future developers on Windows.

Will put up a PR shortly.

mpowa705 avatar Sep 15 '24 02:09 mpowa705