NomNom
NomNom copied to clipboard
Source code ?
Hello. I would like to ask where is the source code ? I would like to submit patch requests for issue fixes.
Hi, thanks for offering help and contribution!
As stated in the README, I will release it here with the first stable/"1.0" version. For now, please submit problems here if you have found any. Add as much information as possible, and with experience in software development and an idea what might cause the problem, every hint is very much appreciated!
Thanks for the heads up. I will add all the information I can.
Could the wait be reconsidered; I'd like to get a better understanding of the changes made to the save structure to simply port between GOG and Windows versions.
It‘s 4 years and we still don't have source code. It seems suspicious to me.
@tylerszabo That part is available as separate lib here, in case you still want to have a look :)
@reserveword No body forces you to use it if you find it suspicious 🤷 In the linked duplicate I also mentioned when I will publish the source code, which I assume from your comment you haven't read. I just posted an update there as well. I outsourced some parts into separate libs (above, here, and here) which are available for quite a while so you can say there is no source code at all ;)
You said in #37 that you do understand that github isn't really meant for just sharing binaries, but that's only half the point. It's a collaborative platform aimed at facilitating development through crowdsourcing. With the only two regularly updated save editors both closed(well as far as decompiling just being annoying to do) it creates a weird situation. The community surrounding the game is embracing the positivity that open communication and trust creates so I suspect it feels strange to many that things remain this closed off.
As you mention that you are limited in time and seeing tickets being opened about supporting updates it does beg the question as to what your aim is keeping things closed. It ultimately might harm your ability to do effective development, because the only way you'll really receive issue tickets is if people can actually use the software. When an update isn't supported the usage is likely nil, so you won't get any feedback until you update things. It makes it much harder for the community to support your development if they can't investigate issues or provide solutions in PRs.
So I'm curious as to what the reason is for keeping it closed.
Hi! First of all: Thanks for your work, @cengelha! I really appreciate it!
I don't know why the source code is locked for now. Perhaps you would like to finish refactoring it before releasing it. Would it be helpful if you invited one or two developers to help you until a public release is possible?
As @Tampa stated, there aren't many alternatives left. It would be great to have this project publicly available and maintainable. It would be a great contribution to the game, and the community devs could help you to build on your initial efforts. :)
It's going in the right direction but actually a little more than that. I'm currently working on a replacement, built with Uno Platform (multi platform incl a web app). Once I'm happy with it, to push the first public (beta) release, I'll make the source code of that version available.
I thought I had it ready by now but it got delayed for various reasons.
The drop of the beta-suffix of the current version a while ago, was already in preparation for the Uno one, for example. The Uno version will be pushed to dev/beta release channels while the current one stays in stable until the new one is ready for it.
The first version is more or less finished but still needs some polishing and some last things added. In terms of actual editing it will just have the JSON editor and some initial things (eg current general tab) but almost everything else should be done by then: settings (migration), updater, save selection, new sections for News and a catalogue, etc
Once the code is public, feel free to join :) Some code is already public (libNOM) so if you want to join, you can have a look at them already. I want to refactor those too, but the top priority is to get the first Uno version done. But as there wasn't much activity or interest to help with the libraries (maintenance, supporting new game version, etc), I'm not really in a hurry to publish the code, but I will eventually 😉
Hope that makes things clearer.