[Bug] Archived tech packages gone from the inventory after editing the save

[roie-r]

The editor doesn't handle archived tech package. Editing anything at all then saving cause archived tech to be deleted from the inventory when loading the game. I think it's something about how arch-tech is represented as hex string that should remain so and not converted to utf8.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (70d03b7) to head (8450d79). Report is 3 commits behind head on master.

Additional details and impacted files

@@      Coverage Diff       @@
##   master   #2955   +/-   ##
==============================
==============================

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lunkwill42]

Link for future reference: twisted/twisted#12239

[lunkwill42]

I've rebased this on the latest master and added a commit to change NAV's requirement to Twisted>=24.7

[lunkwill42]

The above mentioned Twisted PR that changes this behavior seems to suggest that there might be problems using addCallback() or addErrback() on the return values of inlineCallbacks-decorated functions that use plain return. We should verify whether this is a problem (I suspect our test coverage in this area is poor).

[lunkwill42]

The above mentioned Twisted PR that changes this behavior seems to suggest that there might be problems using addCallback() or addErrback() on the return values of inlineCallbacks-decorated functions that use plain return. We should verify whether this is a problem (I suspect our test coverage in this area is poor).

The main PR description mentions this without detail, but delving into the documentation the PR changes, it seems this only applies to functions that are rewritten from using inlineCallbacks decorators to pure Python co-routines (i.e. converting the functions to async def).

This will be a problem for a different PR.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarQube Cloud