KeyboardCowboy icon indicating copy to clipboard operation
KeyboardCowboy copied to clipboard

Notification not showing full sequence for 3+ level

Open ww7 opened this issue 1 year ago • 20 comments

For 3 levels sequences like Fn+V,E,P, bundle notification shows only last key in sequence e.g. P after Fn+V instead of E P.

ww7 avatar Jul 11 '24 11:07 ww7

Yeah, I've noticed this, will investigate and fix this :)

zenangst avatar Aug 30 '24 06:08 zenangst

Figure out a fix for this, will be a part of the next version.

zenangst avatar Sep 01 '24 16:09 zenangst

@ww7 I did some changes in the latest version to fix this issue, would you mind verifying if this is fixed now?

https://github.com/zenangst/KeyboardCowboy/releases/tag/3.25.0

zenangst avatar Oct 24 '24 22:10 zenangst

@zenangst text title in notifications not fit a popup, I think it can be as line under icon and keys or maybe resize popup, or make smaller shortcut, or show shortcut under Icon+title (I'm using Karabiner-Elements to make Space if pressed alone as complex modifier Ctrl+Opt+Cmd)

CleanShot 2024-10-25 at 11 01 41@2x

ww7 avatar Oct 25 '24 08:10 ww7

Now 3-rd level shows full keyboard sequence. Only thing about levels, 2-nd level not informing about existing of 3-d.

ww7 avatar Oct 25 '24 08:10 ww7

Ah, I see now. I think you are right that we need some updates when it comes to the UI.

Only thing about levels, 2-nd level not informing about existing of 3-d.

My idea here was to:

  • First key is pressed
    • Show next level
  • Second key is pressed
    • Expand on next
  • Final key is pressed
    • Show full sequence

zenangst avatar Oct 25 '24 08:10 zenangst

Yeah, but would be good to inform if next level available, like show keys and title "next level" or arrow icon

ww7 avatar Oct 25 '24 08:10 ww7

Not a bad suggestion, I'll see if we can't redesign this for the next version.

zenangst avatar Oct 25 '24 08:10 zenangst

Oh... and thanks a lot for all the feedback, I really appreciate it 😍

zenangst avatar Oct 25 '24 08:10 zenangst

The issue has evolved, so I removed the tags

zenangst avatar Oct 25 '24 13:10 zenangst

@ww7 worked a bit on the redesign just now.

image

zenangst avatar Oct 26 '24 12:10 zenangst

I think align left App icon to Title would be better, as we mostly reading left to right

ww7 avatar Oct 26 '24 13:10 ww7

Made another iteration now

image

zenangst avatar Oct 26 '24 13:10 zenangst

Try place icon to left side in row with keys and align keys to right? Also icon left to the title.

Apple design accent to icons (visual)

ww7 avatar Oct 26 '24 13:10 ww7

Played around with this a bit more.

Now the key that you pressed has less opacity. The next one in the sequence has a glow.

Pretty happy with how it turned out.

image

zenangst avatar Oct 26 '24 15:10 zenangst

Maybe keep Icon with Title?

CleanShot 2024-10-27 at 07 22 36

ww7 avatar Oct 27 '24 05:10 ww7

If icon now at right, maybe also align title to right?

(I believe left side is better for both)

ww7 avatar Oct 31 '24 11:10 ww7

Icons horizontally jumping when loading (older M1, not fastest one)

ww7 avatar Oct 31 '24 11:10 ww7

@ww7 I had to remove an operator because of a crash, will take another stab at this later. Currently my focus is on https://github.com/zenangst/KeyboardCowboy/issues/565

zenangst avatar Nov 01 '24 08:11 zenangst

Recalling issue with notification appearance. CleanShot 2024-12-09 at 07 15 35

  1. Icon showing only for apps? Would it be possible to show also for files?
  2. Notification truncating long sequences. Shift icon can be smaller.
  3. Title would be better to be on the same align as the icon (right)

As for me, icon can be smaller and in same line with the title.

ww7 avatar Dec 09 '24 03:12 ww7