desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Changing keyboard shortcuts, "Conflict with another shortcut"

Open NeoNyxx opened this issue 7 months ago • 2 comments

Captchas

  • [x] I have read the instructions.
  • [x] I have searched existing issues and avoided creating duplicates.
  • [x] I am not filing an enhancement request.
  • [x] I have checked that this issue cannot be reproduced on Mozilla Firefox.
  • [x] I have checked that this issue can be reproduced once I removed all my Mods and Custom CSS.

What happened?

When changing some keyboard shortcuts I get a "Conflict with another shortcut", when I go to find said conflict, I cant find anything, for example, I am used to mapping Ctrl+X to close a tab, setting the shortcut gave me this error, even tho there are no Ctr+X shortcuts anywhere to be seen, so either it's a bug, or there are other shortcuts that are not grouped with these, which is what's causing the error, either way, it's something that needs to be fixed. EDIT: fixing conflicts (when I find them) seems to be working, I just tried setting Ctrl+Shift+N to open a private window instead of Ctrl+Shift+P, and after I got a conflict (the same shortcut is used to undo closed window) I fixed it, which solved the issue.

Version

1.12.5b

What platform are you seeing the problem on?

Windows - x64

What component is this issue related to?

Keyboard Shortcuts

Relevant log output if applicable


NeoNyxx avatar May 18 '25 18:05 NeoNyxx

Ctrl + X is commonly used to cut, maybe there is some internal logic that reserves certain shortcuts as system level and prevents them from being used.

I quickly tried it out with a few common shortcuts I could think of and all of them gave me this error:

  • Ctrl + X (cut)
  • Ctrl + V (paste)
  • Ctrl + C (copy)
  • Ctrl + A (select all)

To add, unless I missed something, Firefox doesn't seem to have the same keyboard shortcut settings like Zen, but it does have extension keyboard shortcuts and when trying to assign Ctrl + C as a shortcut there, I get the error "Can't override a Firefox shortcut" (In Zen the same message is displayed, but with "Zen" instead of "Firefox"). Therefore I don't this is directly a Zen issue. Maybe Zen could add a way to override "reserved" shortcuts as well, though it would require a certain amount of caution and would at least require a clear warning that it could break certain functionality.

jnzd avatar May 18 '25 19:05 jnzd

aaah that makes perfect sense, however I think it can be implemented, but would likely take an ungodly amount of effort, as you need to make a special test for every possible shortcut (for example, if ctrl+x is assigned, let the assigned Zen shortcut only work when no text is selected, same for ctrl+c, etc...). Anyways thanks for the help.

On Sun, May 18, 2025 at 10:16 PM Jonas @.***> wrote:

jnzd left a comment (zen-browser/desktop#8395) https://github.com/zen-browser/desktop/issues/8395#issuecomment-2889160765

Ctrl + X is commonly used to cut, maybe there is some internal logic that reserves certain shortcuts as system level and prevents them from being used.

I quickly tried it out with a few common shortcuts I could think of and all of them gave me this error:

  • Ctrl + X (cut)
  • Ctrl + V (paste)
  • Ctrl + C (copy)
  • Ctrl + A (select all)

To add, unless I missed something, Firefox doesn't seem to have the same keyboard shortcut settings like Zen, but it does have extension keyboard shortcuts and when trying to assign Ctrl + C as a shortcut there, I get the error "Can't override a Firefox shortcut" (In Zen the same message is displayed, but with "Zen" instead of "Firefox"). Therefore I don't this is directly a Zen issue. Maybe Zen could add a way to override "reserved" shortcuts as well, though it would require a certain amount of caution and would at least require a clear warning that it could break certain functionality.

— Reply to this email directly, view it on GitHub https://github.com/zen-browser/desktop/issues/8395#issuecomment-2889160765, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIXH4NKXYHSK3LJ2ECKICML27DL7NAVCNFSM6AAAAAB5MBFD4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBZGE3DANZWGU . You are receiving this because you authored the thread.Message ID: @.***>

NeoNyxx avatar May 18 '25 19:05 NeoNyxx

Hi, @NeoNyxx. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • You reported an issue with changing keyboard shortcuts in Zen, encountering a conflict error.
  • jnzd suggested that some shortcuts, like Ctrl+X, might be reserved for system functions.
  • You acknowledged the complexity of implementing a solution to allow reassignments without conflicts.
  • The discussion leaned towards considering a feature to override reserved shortcuts cautiously.

Next Steps:

  • Please let us know if this issue is still relevant to the latest version of the desktop repository by commenting here.
  • If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

dosubot[bot] avatar Jun 21 '25 16:06 dosubot[bot]