desktop icon indicating copy to clipboard operation
desktop copied to clipboard

After clicking the URL, the padlock menu is broken

Open galfonso99 opened this issue 8 months ago • 7 comments

Captchas

  • [x] I have read the instructions.
  • [x] I have searched existing issues and avoided creating duplicates.
  • [x] I am not filing an enhancement request.
  • [x] I have checked that this issue cannot be reproduced on Mozilla Firefox.
  • [x] I have checked that this issue can be reproduced once I removed all my Mods and Custom CSS.

What happened?

When using the single toolbar layout clearing cookies fails. I have to change layout to successfully clear cookies. I believe this has to do with the UI for clearing cookies from the single toolbar being different than the rest because of less width.

System: MacOS Intel

Steps to Reproduce:

  1. Open zen on a fresh profile
  2. Make sure you are on single toolbar layout
  3. Navigate to youtube.com
  4. Click on the address bar
  5. Click on the lock
  6. Click on Clear cookies
  7. Clearing cookies failed

Version

1.11.5b

What platform are you seeing the problem on?

macOS - Intel

What component is this issue related to?

URL Bar

Relevant log output if applicable


galfonso99 avatar Apr 24 '25 17:04 galfonso99

When using the single toolbar layout clearing cookies fails. 7. Clearing cookies failed

@galfonso99 Can you elaborate what exactly do you mean by fail, do you see any error message or don't see the dialog box ? Are you able to still clear cookies via about:preferences#privacy or Command (⌘) + Shift + Delete shortcut?

0Ky avatar May 21 '25 16:05 0Ky

@0Ky I see the problem on why you or someone else might not be able to replicate this issue. Alright so when you click on the url bar (in compact mode) such that the url is highlighted and the lock icon is on the left (IMPORTANT), when you click the lock and then click clear cookies the pop up that should show up to confirm does not show up and the tab bar simply closes erraticly but no error is reported. I haven't looked at logs nor do I yet know how to. There is however a way where this error does not occur, and that is by not clicking the url bar and simply hovering the lock icon will show up on the RIGHT. By following the usual steps then the cookies clearing will be successful. So to recap, if you click the url bar first before attempting to clear cookies it simply wont work. All of this has been now tested on 1.12.5b and 1.13t P.S. Yes I am able to clear cookies by other methods

galfonso99 avatar May 21 '25 17:05 galfonso99

when you click on the url bar (in compact mode) such that the url is highlighted and the lock icon is on the left (IMPORTANT)

Ah, thanks for pointing that out. I didn't follow your steps correctly, my bad. It turns out you have to click on the URL address bar first. I was hovering over it and clicking the lock icon that appears on the right side of the address bar instead.

Yes, I can confirm that this issue is reproducible in version 1.13t on both Linux and Windows operating systems too.

0Ky avatar May 21 '25 19:05 0Ky

Thank you so much. Yeah I guess since you can just hover to achieve the same task this bug is not very urgent, but I would still consider it a bug nonetheless

galfonso99 avatar May 21 '25 19:05 galfonso99

Can repro.

For immediate clarity:

This first padlocks menu works:

Image

This left side (second) padlock after clicking in the url bar doesn't:

Image

Neither viewing the certificate nor clearing cookies is possible.

@galfonso99 Could you change the title of the issue to indicate it's about a broken (second) padlock menu ++ remove the 'when using single toolbar layout'? In my testing this also happens in multiple toolbar and collapsed layouts when first clicking in the url bar.

Propheticus avatar May 22 '25 20:05 Propheticus

Not sure if this helps at all, but I was able to partially fix the issue by modifying the following condition to also ignore events that come from the #identity-popup, so the sidebar doesn't collapse when interacting with the identity popup panel:

https://github.com/zen-browser/desktop/blob/9132019cb3e4ba35729c5af30af00a6d0df85139/src/zen/compact-mode/ZenCompactMode.mjs#L561-L568

I updated the mousedown event handler to prevent the view from closing when clicking inside the #identity-popup. I also added a check to only call Services.focus.clearFocus(window); if the #navigator-toolbox (sidebar) doesn't have the zen-has-hover attribute, to avoid blurring the URL bar's text input, but this seems like a hacky approach.

I said it fixes partially, because navigating back from the "Connection Secure" button within the popup panel results in the same issue.

0Ky avatar May 22 '25 20:05 0Ky

@galfonso99 Could you change the title of the issue to indicate it's about a broken (second) padlock menu ++ remove the 'when using single toolbar layout'? In my testing this also happens in multiple toolbar and collapsed layouts when first clicking in the url bar.

Changed the title let me know if its fine or what to change it to more specifically. I now realize that the reason that I got it working in the multiple toolbars was because it was more obvious to access the first nonbroken padlock menu. I simply did not realize I had to hover then look right to find the padlock on single toolbar haha.

galfonso99 avatar May 23 '25 16:05 galfonso99

I want to add that this happens with any icon on the floating urlbar. It also doesn't let you interact with the popup/flyout menu of the Privacy Protections icon (if enabled with zen.urlbar.show-protections-icon) or the website permissions icon (for example to revoke Microphone permission given to a website)

AuraHerreroRuiz avatar May 27 '25 16:05 AuraHerreroRuiz

Reproducable on Windows 1.12.10b and Linux 1.12.10t

https://github.com/user-attachments/assets/a1f18bc9-a7e5-46d8-9d6c-f80a381643e8

kenblu24 avatar Jun 03 '25 14:06 kenblu24

It seems like the problem started in 1.11.3, because here's what the old behavior was on 1.11.2 AppImage:

https://github.com/user-attachments/assets/5e775989-a82d-4afa-b53d-42624a51456f

kenblu24 avatar Jun 03 '25 14:06 kenblu24

Hi, @galfonso99. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • The padlock menu malfunctions when clearing cookies in the single toolbar layout on macOS Intel, starting from version 1.11.5b.
  • The issue is confirmed on Linux and Windows by 0Ky.
  • Propheticus suggested updating the title to reflect the issue's broader scope across different toolbar layouts.
  • AuraHerreroRuiz noted similar issues with other icons on the floating URL bar.
  • Kenblu24 traced the problem's origin to version 1.11.3.

Next Steps:

  • Please confirm if this issue is still relevant to the latest version of the desktop repository by commenting here.
  • If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

dosubot[bot] avatar Jul 04 '25 16:07 dosubot[bot]

This issue is still occurs in version 1.14.2b.

AuraHerreroRuiz avatar Jul 06 '25 15:07 AuraHerreroRuiz

Hello,

I can confirm that this issue is still present. I am experiencing the same bug where clicking "Clear cookies and site data" does not work as expected when the URL bar is active or in focus.

My specific observation aligns with the steps described:

  1. Open Zen Browser.
  2. Navigate to any website.
  3. Click into the URL bar or shortcut Ctrl+L to make it active.
  4. Then, click the padlock icon next to the URL.
  5. Click "Clear cookies and site data."

The confirmation dialog does not appear, and the site data/cookies are not cleared, meaning I remain logged in to that specific site. However, if I hover over the URL bar without clicking into it first, then click the padlock and proceed, the functionality works correctly.

This seems to be directly related to the URL bar's active state.

Zen Browser Version: v1.14.4b

Thank you for looking into this.

roubilibo avatar Jul 10 '25 11:07 roubilibo

Hi, @galfonso99. I'm Dosu, and I'm helping the desktop team manage their backlog and am marking this issue as stale.

Issue Summary:

  • You reported that clearing cookies via the padlock menu fails when the URL bar is clicked first in Zen Browser 1.11.5b on macOS Intel.
  • The issue is reproducible on Linux and Windows, linked to the sidebar collapsing when interacting with the identity popup.
  • Other users confirmed the bug affects multiple toolbar layouts and floating URL bar icons, introduced around version 1.11.3.
  • The problem remains unresolved as of version 1.14.4b, with continued reports of the bug when the URL bar is active.

Next Steps:

  • Please let me know if this issue is still relevant with the latest version of the desktop repository by commenting here to keep the discussion open.
  • If I don’t hear back within 7 days, I will automatically close this issue.

Thank you for your understanding and contribution!

dosubot[bot] avatar Aug 10 '25 16:08 dosubot[bot]

Not stale, reproducible on 1.14.10b

ForLoveOfCats avatar Aug 10 '25 19:08 ForLoveOfCats

@mr-cheffy Could dosubot please be told to not mark issues 'stale' that have been triaged and have a to-do status?

Propheticus avatar Aug 11 '25 14:08 Propheticus

For me padlock menu works only in "Multiple toolbars" mode, and only sometimes.

video

https://github.com/user-attachments/assets/8877f649-5216-4371-b0a6-c16da53546d8

fixator10 avatar Aug 23 '25 10:08 fixator10

For me padlock menu works only in "Multiple toolbars" mode, and only sometimes. video

That's because you first clicked in the URL bar. That's the exact issue being reported here. When you only hover over the URL bar (don't click) so that the padlock shows and then click it, it works.

Propheticus avatar Aug 26 '25 11:08 Propheticus

Still happening on 1.15.5 and windows. Unrelated to compact mode and toolbar mode #10330

Alintya avatar Sep 12 '25 13:09 Alintya

Still happening on 1.15.5b macos arm.

https://github.com/user-attachments/assets/0b2be0fa-4dcb-4747-a3db-e3ecbf9e2f28

benni347 avatar Sep 18 '25 13:09 benni347

This appears fixed with the new site setting button/popup.

Clicking the url bar, then the settings, then the 'secure' button works.

Image

Propheticus avatar Oct 17 '25 18:10 Propheticus