Tab unloading fails on tabs using the Glance view

[0Ky]

Captchas

• [x] I have read the instructions.
• [x] I have searched existing issues and avoided creating duplicates.
• [x] I am not filing an enhancement request.
• [x] I have checked that this issue cannot be reproduced on Mozilla Firefox.
• [x] I have checked that this issue can be reproduced once I removed all my Mods and Custom CSS.

What happened?

The Tab Unloading function stops working on any type of tab (normal, pinned or essential) that's using the Glance feature. Once you attempt to unload a tab with Glance view active, the unload functionality from the right click context menu stops working for that tab, even after the Glance view is closed.

Steps to Reproduce

1. Press Ctrl + T to open a new tab and navigate to any website.
2. Alt + Click on a hyperlink to open it in the Glance view.
3. Switch to another tab.
4. Right-click on the Glance tab and select Unload Tab.
5. * Observe that the tab is not unloaded.
6. Switch back to the Glance tab and close the Glance view.
7. Repeat steps 3 and 4.
8. * Observe that the tab still cannot be unloaded, even though the Glance view is closed.

Version

1.11.3t

What platform are you seeing the problem on?

Windows - x64, Linux (AppImage)

What component is this issue related to?

Tab unloading

Relevant log output if applicable

[sporocyst]

1.11.3b / windows 10 As observing about:processes, In step 5, I can see the tab is dimmed, the original page is unloaded, but the glance page exists. In step 8, tabs can be unloaded as usual.

[0Ky]

@sporocyst In Step 5. are you referring to the Glance tab, a tab that has an active Glance view? The dimmed tab you're referring to should have 2 favicons on it, just like this: . Is that correct ?

[sporocyst]

sure

[0Ky]

@sporocyst I was only asking to verify because I'm testing on different platforms (Linux, Windows 10 and Windows 11) with clean profile configurations and the results do not match at all with what you previously commented. Which makes me think it's either a user error or that you're testing in a personal environment where settings have been modified.

I can confirm that this issue exists in versions 1.11.2b, 1.11.3b, 1.11.3t and a custom build from source using commit dd005b31a460e21e1c6d9a35fce39aa0961aaff9.

[sporocyst]

I figured the reason out. Because I unload tabs through option in context menu out of pref browser.tabs.unloadTabInContextMenu, not the one appears along with zen.tab-unloader.enabled

[dosubot[bot]]

Hi, @0Ky. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

• The Tab Unloading function is not working for tabs using the Glance view in version 1.11.3t.
• The issue occurs on both Windows and Linux platforms.
• User sporocyst noted different behavior due to using a different context menu option.
• You confirmed the issue persists across multiple versions and platforms.
• The problem might be related to specific settings or configurations.

Next Steps:

• Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here.
• If there is no further activity, I will automatically close this issue in 7 days.

Thank you for your understanding and contribution!

[0Ky]

@mauro-balades 76c22cc does not fix this issue, please refrain closing issues without first verifying the resolution with the issue author, request a retest before closing the issue. It's important to ensure the problem is fully addressed before marking it as resolved.

The test was conducted with the latest build from Actions (6 hours ago), where 76c22cc (12 hours ago) should have been included. I followed the exact same steps to reproduce the issue as described in the OP and I'm still able to reproduce it.

[mr-cheffy]

Right, I linked the wrong issue, my bad.

[dosubot[bot]]

Hi, @0Ky. I'm Dosu, and I'm helping the desktop team manage their backlog and am marking this issue as stale.

Issue Summary:

• The Tab Unloading function fails for tabs using the Glance view in version 1.11.3t on Windows and Linux.
• Sporocyst initially observed different behavior due to a different context menu option but later identified the cause related to specific settings.
• I previously marked the issue as stale, prompting you to confirm if the issue persists.
• Mr-cheffy acknowledged linking the wrong issue, indicating ongoing confusion in resolving the problem.

Next Steps:

• Please confirm if this issue is still relevant to the latest version of the desktop repository. If so, you can keep the discussion open by commenting on the issue.
• Otherwise, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!