Inconsistent Tab Unload When Disabled (Context Menu Item Missing)

[0Ky]

Captchas

• [x] I have read the instructions.
• [x] I have searched existing issues and avoided creating duplicates.
• [x] I am not filing an enhancement request.
• [x] I have checked that this issue cannot be reproduced on Mozilla Firefox.
• [x] I have checked that this issue can be reproduced once I removed all my Mods and Custom CSS.

What happened?

When the Tab Unloader feature or zen.tab-unloader.enabled preference is disabled, the "Unload Tab" option is removed from the right-click context menu. However, users are still able to unload pinned and essential tabs via pressing on the - unload button, using keyboard shortcut Ctrl + W or mouse middle-click.

This behavior seems inconsistent with the expectation that disabling the Tab Unloader feature should only stop automatically unloading tabs.

Steps to Reproduce

1. Disable Tab Unloader or set zen.tab-unloader.enabled to false.
2. Observe that the "Unload Tab" right-click context menu item is no longer available.
3. Try unloading a pinned or essential tab by clicking on the - button, using Ctrl + W or mouse middle-click.
4. Tab still unloads despite being unable to unload using the right-click context menu.

Actual Result

The Unload Tab right-click context menu item is removed when disabling the feature to automatically unload tabs, while still being able to unload tabs through other methods.

Expected Result

Disabling the automated Tab Unloader feature should not remove the ability to manually unload normal tabs from the right-click context menu.

Suggested Fixes / Improvements

In addition to the expected result I would like to suggest the following to prevent the accidental unloading or even closure of pinned and essential tabs to keep the behavior consistent, which also aligns with Mozilla Firefox, as it does not have a close button from the tab bar to intentionally prevent accidental closure.

1. The unload button on hover for pinned tabs should be removed.
2. The close tab button on hover for pinned tabs should be removed.
3. Shortcuts like Ctrl + W should not unload pinned and essential tabs.

Version

1.11.2t

What platform are you seeing the problem on?

Linux (AppImage), Linux (Flatpak), Linux (Tarball), Windows - x64, Windows - aarch64, macOS - aarch64, macOS - Intel, Other

What component is this issue related to?

Tab unloading

Relevant log output if applicable