desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Initial implementation for folders and tree-styled tabs

Open mr-cheffy opened this issue 8 months ago • 33 comments

Functionality:

  • [x] Make firefox groups work only for pinned tabs
  • [x] Correctly restore folders to their designated workspaces after a restart
  • [x] Allow folders to stack up together
    • [x] Split view groups should be able to fit inside folders

UI/UX:

  • [ ] Rename input when creating a folder
  • [x] Open / Close animations (excluding selected tab)
  • [ ] Allow drag and dropping folders
  • [x] Allow droping tabs inside folders

mr-cheffy avatar Apr 05 '25 18:04 mr-cheffy

Make firefox groups work only for pinned tabs

Why make it only work for pinned tabs, why not both?

MoshiurRahmanAdib avatar Apr 07 '25 07:04 MoshiurRahmanAdib

Because normal tabs should be disposable. I have another thing planned for normal tab grouping. This PR is just for folders

mr-cheffy avatar Apr 07 '25 09:04 mr-cheffy

For the nested folder and split view, I feel like it might be easier to match the parent margin like attached. This would ensure that the split view has enough room. I feel like at some point, there should be a max nested folder size or a way to configure the max size.

Lastly, I am wondering if we should have a config option for the indent size? I know there is a number of people that set theirs to 0 to keep it kinda flat.

image

logicsec avatar Apr 08 '25 12:04 logicsec

I believe max should be 4 or 5, depending on how it turns out to be. First step is to actually get them... stacked. And for spacing, it should be logarithmic, where the more indents there are, the lower the spacing would be

mr-cheffy avatar Apr 08 '25 13:04 mr-cheffy

Because normal tabs should be disposable. I have another thing planned for normal tab grouping. This PR is just for folders

So should we ignore the title of this PR having “tree style tabs” in it? Will there be another PR opened for that? Or is this the single PR we can follow for tree style tabs as well?

Thanks!

GitMurf avatar Apr 09 '25 23:04 GitMurf

Tree style tabs imply folders need to be stackable

mr-cheffy avatar Apr 10 '25 13:04 mr-cheffy

Because normal tabs should be disposable. I have another thing planned for normal tab grouping. This PR is just for folders

There are situations where I need to sort my normal tabs and keep them open for an extended period of time but don’t want to pin them. For instance, I’m making a modpack for Minecraft right now. When I’m researching mods, I open ones I’m considering in new tabs and sort them into groups by category (currently just using the somewhat working Firefox tab groups). These tabs are still disposable, since they’ll be closed eventually, but they’re still open long enough that they need good organization.

If your plan for tab groups covers this, then cool. If it doesn’t, then I don’t see why users can’t have the choice to use folders for normal tabs if they want

Hikiru avatar Apr 10 '25 14:04 Hikiru

Is there a estimation for the release of this feature? I wanna suggest my team migrate to use Zen instead of Arc but this o course will be a discussion point 😂

solrac97gr avatar Apr 10 '25 16:04 solrac97gr

There are situations where I need to sort my normal tabs and keep them open for an extended period of time but don’t want to pin them. For instance, I’m making a modpack for Minecraft right now. When I’m researching mods, I open ones I’m considering in new tabs and sort them into groups by category (currently just using the somewhat working Firefox tab groups). These tabs are still disposable, since they’ll be closed eventually, but they’re still open long enough that they need good organization.

Yeah, as I said, there's a third type of group planned for normal tabs. But I dont think they'll appear on the same release as folders.

So it would end up being:

  • Split view group
  • Folder
  • Temp. Group

once zen reaches stable

mr-cheffy avatar Apr 10 '25 18:04 mr-cheffy

Yeah, as I said, there's a third type of group planned for normal tabs.

@mauro-balades makes sense and thanks for the clarifications! My only follow-up question is whether this third type of group for normal tabs will also support tree style tab primitives, meaning can have nested groups N levels deep (which I believe you refer to as "stackable")? Thanks!!

GitMurf avatar Apr 10 '25 19:04 GitMurf

Is there a estimation for the release of this feature? I wanna suggest my team migrate to use Zen instead of Arc but this o course will be a discussion point 😂

Soon, I do want to give this feauter a nice week of purely testing as it's one of the things most people request.

@mauro-balades makes sense and thanks for the clarifications! My only follow-up question is whether this third type of group for normal tabs will also support tree style tab primitives, meaning can have nested groups N levels deep (which I believe you refer to as "stackable")? Thanks!!

That's still has to be decided on, im still unsure about normal tabs implementation. Im focusing on pinned tabs right now, sorry

mr-cheffy avatar Apr 10 '25 20:04 mr-cheffy

For drag and drop, we might just have to update to Firefox beta (138) since they already have this functionality...

mr-cheffy avatar Apr 11 '25 20:04 mr-cheffy

I don't think it should be so overcomplicated. You don't need three different things that are all folders. I agree you should focus on pinned tab folders right now, but please call it one name.

g3eorge avatar Apr 11 '25 21:04 g3eorge

Yeah, I'm just spitting out technicalities. Split views are just split views, but they are just groups at the end of the day

mr-cheffy avatar Apr 12 '25 09:04 mr-cheffy

so this is the spoiler for the new feature

Sabreclaw avatar Apr 13 '25 09:04 Sabreclaw

@mauro-balades appreciate the hard work you do for Zen! Just curious if you had any updates on timeline for this MR? I've been eagerly awaiting implementation of this feature since this MR first opened.

smalhotra3599 avatar Apr 24 '25 23:04 smalhotra3599

Twilight is already on firefox 138, once I get that release out of the way, Ill start working on finishing the last details for this PR. Behind the scenes, I already found folder icons with animations and patched firefox to properly work with folders.

mr-cheffy avatar Apr 27 '25 13:04 mr-cheffy

Love the work you are doing here. Currently using Zen with "Tree Style Tab" plugin in order to achieve something usable and useful for my tastes, however as it is a plugin and fights with the native tab appearance/implementation in Zen, it still isn't ideal. Sideberry also isn't quite cutting it for me as well.

All of your efforts spent in the vertical tab space and on nested/tree-style-tabs gets a ton of support from me! Keep up the great work! Tons of people will find this all exceptionally useful.

InJJWeTrust avatar Apr 28 '25 07:04 InJJWeTrust

@mauro-balades are you keeping the current tab groups and just adding tab folders on top of that API?

logicsec avatar Apr 28 '25 12:04 logicsec

sigma software

xptea avatar May 03 '25 22:05 xptea

This is the only think that kept me from switching to Firefox. Now it's here.

I can't wait for this to get released here so I can make the full switch and finally ditch Chrome.

That's awesome. Thank you @mauro-balades

azeveco avatar May 09 '25 21:05 azeveco

Once 1.12.4b is released ill start working back again with this. Releasing today.

mr-cheffy avatar May 13 '25 13:05 mr-cheffy

I'm just here to persist the hype

jd-santos avatar May 18 '25 20:05 jd-santos

Waiting for it

agarwal222 avatar May 18 '25 20:05 agarwal222

@agarwal222 @jd-santos do you have notifications for this PR enabled, too? :D

bpavuk avatar May 18 '25 20:05 bpavuk

@bpavuk ofc bro, this feature is the only one that is keeping me from switching from Arc, for my personal use

agarwal222 avatar May 18 '25 20:05 agarwal222

@bpavuk ofc bro, this feature is the only one that is keeping me from switching from Arc, for my personal use

Same 😂

kevinrobayna avatar May 18 '25 22:05 kevinrobayna

@jd-santos @bpavuk @agarwal222 @kevinrobayna i suggest you take this discussion elsewhere. people are tracking this PR for actual development updates and feature enhancement.

Vortriz avatar May 18 '25 22:05 Vortriz

Poll

Like this comment if you think that tab folders should work only with pinned tabs, and dislike this comment if you think it should work with non-pinned tabs as well.

g3eorge avatar May 20 '25 02:05 g3eorge

↑ And heart if you'd love them to support non-pinned tabs, but would rather have something than blocking this on trivialities.

lishaduck avatar May 20 '25 02:05 lishaduck