Moving `Bookmark toolbar items` to sidebar && Closing and reopening `Customize toolbar…` expands bookmarks in `Customize toolbar…`

[Brambor]

Captchas

• [x] I have read the instructions.
• [x] I have searched existing issues and avoided creating duplicates.
• [x] I am not filing an enhancement request.
• [ ] I have checked that this issue cannot be reproduced on Mozilla Firefox.
• [x] I have checked that this issue cannot be reproduced once I removed all my Mods and Custom CSS.

What happened?

The problem

In the top bar, Bookmark toolbar items shows as the abstract thing while customizing:

When put onto the sidebar, it is still abstract:

When closing and opening the customize tab, it is no longer abstract, it is expanded:

It cannot be moved and removing it is hard (I thought it cannot be done).

What happened?

Moving bookmarks down here in the Customize toolbar… makes the sidebar span the whole chrome:

The only way I found to use the browser with that is to right-click and compact mode > enable compact mode. If it doesn't hide right away, put your mouse cursor to a spot in the bottom right of the screen to hide the sidebar.

It cannot be easily removed (except for reset to default).

• Cannot be right-clicked to delete.
• Cannot be dragged.
• I managed to right click it on the very left and remove it.

Version

Found in: 1.7.4b (Firefox 134.0.2) (64-bit)

The issue still persists in: 1.10.3b (64-bit)

What platform are you seeing the problem on?

Windows - x64

What component is this issue related to?

Customizable UI / Toolbars

Relevant log output if applicable

[Propheticus]

Can recreate in 1.11.2t . You were able to find a nice edge-case. The simple advise for now: don't drag bookmark toolbar items to the sidebar. 🤓

The behaviour on Twilight seems to have changed somewhat and an 'overflow menu' (with a >) is created if there are more bookmarks than there's space instead of expanding the sidebar to the full width:

The other part of the issue : expanded and non-abstract representation of bookmarks during 'customise toolbar' remains. So after placing the bookmarks in the sidebar there's no easy way to (re)move them other than a restore defaults + disable/enable bookmarks toolbar trickery.

The items repo at the bottom also shows an unusable 'bookmarks toolbar items' item:

[dosubot[bot]]

Hi, @Brambor. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

• The issue involves the browser's customizable UI, specifically with bookmark toolbar items becoming difficult to manage when moved to the sidebar.
• Propheticus confirmed the issue in version 1.11.2t, noting an overflow menu appears with too many bookmarks.
• The problem persists with expanded bookmarks during toolbar customization, with no straightforward removal or manipulation method.
• The current workaround involves restoring defaults and toggling the bookmarks toolbar.

Next Steps:

• Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here to keep the discussion open.
• If no further input is provided, I will automatically close this issue in 7 days.

Thank you for your understanding and contribution!

[Brambor]

Should I keep bringing up it is still relevant?

In other team, we let the issues close. They are still valid. But nobody is willing to work on them.

[SO9010]

Feels like to me that it shouldn't be able to go onto the sidebar at all...

Edit: It should be but it should get constrained

[Brambor]

Feels like to me that it shouldn't be able to go onto the sidebar at all...

Edit: It should be but it should get constrained

I want it to be a horizontal list in the sidebar rather than vertical, like you can get... somewhere I forgot. I don't use Zen since it is too slow.

[dosubot[bot]]

Hi, @Brambor. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary

• The issue involves difficulty managing bookmark toolbar items when moved to the sidebar.
• @Propheticus confirmed the issue in version 1.11.2t, noting an overflow menu appears instead of full expansion.
• The problem with expanded bookmarks during customization persists.
• @SO9010 suggested constraining bookmarks in the sidebar; you prefer a horizontal list format.

Next Steps

• Please confirm if this issue is still relevant in the latest version of the desktop repository by commenting here.
• If there is no further activity, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

[Brambor]

I don't suppose anyone fixed it.

[nasserd]

I'm just seeing this but it seems like two things: (1) issue is not clear [is there more than 1 bug at play?] and (2) these bugs are seemingly inherited from upstream Firefox project.

There's no PR addressing this edge case, but it does present an interesting user requirement... So you want a full-width horizontal bookmarks bar coming out from the sidebar? It's not clear what the desired layout is; a different combination of settings might accomplish the same objective...

[Brambor]

No matter what I want. Keep the bookmarks abstract so that when user does what I did, they don't get into a state that is seemingly impossible to get from. I ended up resetting the customizstion (a couple of times).

Making it not possible to move to the sidebar is a valid solution. I see that now.

[dosubot[bot]]

Hi, @Brambor. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

• The issue involves managing bookmark toolbar items in Firefox's customizable UI when moved to the sidebar.
• Propheticus confirmed the issue in version 1.11.2t, noting an overflow menu appears instead of full expansion.
• Discussions included potential solutions like constraining bookmarks or preventing sidebar movement.
• You agreed that preventing movement to the sidebar could be a valid solution.

Next Steps:

• Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here.
• If there are no updates, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

[Brambor]

I don't want to recheck it, because it would break my browser again. I use Zen as my primary browser now, since Chrome unsupports uBlock.

Why not have a "Confirmed bug" label like in https://github.com/CleverRaven/Cataclysm-DDA/labels?q=confirmed ? Then, people making valid bug reports aren't pinged whether the bug stopped being valid.

Developers can just slap on "low priority".

[dosubot[bot]]

Hi, @Brambor. I'm Dosu, and I'm helping the desktop team manage their backlog and am marking this issue as stale.

Issue Summary:

• You reported that bookmark toolbar items appear as abstract elements in the Customize Toolbar interface and are difficult to move or remove.
• Moving these items to the sidebar causes layout issues, with an overflow menu appearing instead of full sidebar expansion.
• The core problem of managing bookmarks during customization remains unresolved despite discussions and suggestions.
• You agreed that preventing bookmarks from being moved to the sidebar might be a valid solution.
• No fix has been implemented yet, and you suggested adding a "Confirmed bug" label to prevent repeated stale notices.

Next Steps:

• Please let me know if this issue is still relevant with the latest version of the desktop repository by commenting here to keep the discussion open.
• Otherwise, this issue will be automatically closed in 10 days.

Thank you for your understanding and contribution!

[Brambor]

.