desktop icon indicating copy to clipboard operation
desktop copied to clipboard

ci: add winget releaser workflow

Open sitiom opened this issue 1 year ago • 7 comments

This action automatically generates manifests for Winget Community Repository (microsoft/winget-pkgs) and submits them.

The Zen Browser package is being added to Winget (https://github.com/microsoft/winget-pkgs/pull/168940, https://github.com/microsoft/winget-pkgs/pull/168942), and this workflow will be used to update it.

Before merging this:

  1. Ensure the ${{ secrets.DEPLOY_KEY }} token has the public_repo permission:

example

  1. Fork https://github.com/microsoft/winget-pkgs under @zen-browser. The action will use that fork for making a branch and creating a PR with the upstream winget-pkgs repository on every release.
  2. Install Pull on the winget-pkgs fork to ensure that it is constantly updated.

If you want to see an example of a PR created using this action, see microsoft/winget-pkgs/pulls (Pull request has been created with WinGet Releaser).

sitiom avatar Aug 25 '24 02:08 sitiom

  1. Ensure the ${{ secrets.DEPLOY_KEY }} token has the public_repo permission

Could we get that done in the CI by using the PAT from GH actions and specifying it's permissions?

Zykkl avatar Aug 25 '24 22:08 Zykkl

Sidenote, ZenBrowser.Zen also exists, I don't know if we can do something about there now being 2 IDs for the browser.

Zykkl avatar Aug 25 '24 22:08 Zykkl

Could we get that done in the CI by using the PAT from GH actions and specifying it's permissions?

No, you can't. The PAT is used to make a commit and create a PR from an external repo.

Sidenote, ZenBrowser.Zen also exists, I don't know if we can do something about there now being 2 IDs for the browser.

  • https://github.com/microsoft/winget-pkgs/pull/169157

sitiom avatar Aug 26 '24 02:08 sitiom

Would using on: release avoid/fix the issue? So rather than it running with the main pipeline, it would run by itself whenever a new release is out. (Example https://github.com/microsoft/devhome/blob/94fde2349d7666575f28daf54451668f0acdbf4c/.github/workflows/winget-submission.yml#L3C1-L6C23).

Zykkl avatar Aug 29 '24 09:08 Zykkl

How would we sign it though? My license key is physical

mr-cheffy avatar Aug 29 '24 18:08 mr-cheffy

The action would only run when you publish a release, so you'd still be able to sign your stuff

Zykkl avatar Aug 29 '24 18:08 Zykkl

I just want to get everything signed and working before expanding to more windows sites... But this will be merged

mr-cheffy avatar Sep 08 '24 10:09 mr-cheffy

Closed?

sitiom avatar Oct 15 '24 22:10 sitiom

Try changing the base branch to dev or opening a new PR

UnownPlain avatar Oct 16 '24 01:10 UnownPlain