desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Compact Tabbar Broken

Open NatryN opened this issue 1 year ago • 6 comments

Captchas

  • [X] I have read the instructions.
  • [X] I am not filing an enhancement request.
  • [X] I have searched existing issues and avoided creating duplicates.

What happened?

image I just update zen browser, how can i fix my tabbar.

Reproducible?

  • [X] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.8

What platform are you seeing the problem on?

Linux

Relevant log output

No response

NatryN avatar Oct 11 '24 20:10 NatryN

Also experiencing this, for me it seems to only affect tabs opened in workspaces that previously had no open tabs (just the auto created empty / new tab) before the a.8 update, workspaces that had tabs open before the update the sidebar looks like it normally should when collapsed in compact mode.

sjclayton avatar Oct 11 '24 21:10 sjclayton

Maybe related - #2015

sjclayton avatar Oct 11 '24 21:10 sjclayton

I pin a tab and it look better, but I want that but without pining a tab. image

NatryN avatar Oct 11 '24 21:10 NatryN

@NatryN

What happens if you unpin the tab... Does the bug re-appear or do the tabs look normal?

sjclayton avatar Oct 11 '24 22:10 sjclayton

@NatryN

What happens if you unpin the tab... Does the bug re-appear or do the tabs look normal?

the bug re-apper

NatryN avatar Oct 11 '24 22:10 NatryN

+1, also wanna add that the paddings in this implementation are quite ugly, especially compared to the Floating Compact Sidebar extension (that's now broken). How about just implementing the extension as a switch in settings?

Screenshot 2024-10-13 184939 With the extension enabled, ignore the now broken shadows, notice the equal padding relative to the page

Screenshot 2024-10-13 184950 Without the extension, notice the offset, especially vertically

antikovt avatar Oct 13 '24 17:10 antikovt

This has been fixed and will be available in the next Zen Browser Release.

Fixed on: Zen Twilight Build

This might be related: https://github.com/zen-browser/desktop/commit/e840184e7fac54d523e8a4fd61b73b44ae33419c

scanash00 avatar Oct 13 '24 22:10 scanash00

This has been fixed and will be available in the next Zen Browser Release.

Have the paddings been adjusted too?

antikovt avatar Oct 13 '24 22:10 antikovt

This has been fixed and will be available in the next Zen Browser Release.

Have the paddings been adjusted too?

Probably, yes. https://github.com/zen-browser/desktop/commit/e840184e7fac54d523e8a4fd61b73b44ae33419c

scanash00 avatar Oct 13 '24 22:10 scanash00

You can always try it yourself by dowloading the twilight build at https://github.com/zen-browser/desktop/releases/tag/twilight

scanash00 avatar Oct 13 '24 22:10 scanash00

This has been fixed and will be available in the next Zen Browser Release.

Fixed on: Zen Twilight Build

This might be related: e840184

Downloaded v1.0.1-a.9 today morning. Looks like the issue didn't get fixed. I am on Arch btw.

Edit: Seems like the problem is with Floating Compact Sidebar Zen Mod.

1728959991_grim

FireDrop6000 avatar Oct 15 '24 02:10 FireDrop6000

The issue with the icons being cut off is resolved for me in 1.0.1-a.9 on Linux.. any other issues that would appear related to this are probably being caused by mods.

This can probably be closed now.

sjclayton avatar Oct 15 '24 06:10 sjclayton

Sourds good!

mr-cheffy avatar Oct 15 '24 13:10 mr-cheffy

Have the paddings been adjusted too?

Probably, yes. e840184 You can always try it yourself by dowloading the twilight build at https://github.com/zen-browser/desktop/releases/tag/twilight

Sadly, no, the paddings of the tabbar still visually conflict with the paddings of the compact view. Idk if anyone will ever get to changing this or if people would agree with me, but I think the paddings used in the extension I linked higher in the chain are much more visually appealing.

Screenshot 2024-10-26 234306

antikovt avatar Oct 26 '24 21:10 antikovt