desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Web panels get unloaded / reloaded on every toggle

Open sjclayton opened this issue 1 year ago • 4 comments

Captchas

  • [X] I have read the instructions.
  • [X] I have searched existing issues and avoided creating duplicates.
  • [X] I am not filing an enhancement request.

What happened?

Every time I use the sidebar button or keyboard shortcut to toggle the web panel, all panels get reloaded thus losing their last state. This was not the case with 1.0.1-a.7

Expected result:

When the web panel is toggled the panels open to the last state they were in previously.

Reproducible?

  • [ ] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.8

What platform are you seeing the problem on?

Linux

Relevant log output

No response

sjclayton avatar Oct 11 '24 12:10 sjclayton

This is happening to me too but every web panel unloads/reloads.

Edit: Just noticed that the panels stay loaded until I reopen the sidebar.

Axenide avatar Oct 11 '24 18:10 Axenide

@Axenide

You appear to be correct, I don't know why it appeared that only the last active panel got unloaded/reloaded on toggle. It is definitely all of them.

EDIT: Updated issue to correctly align with this behaviour.

sjclayton avatar Oct 11 '24 18:10 sjclayton

Yes, I can confirm this too. The web panel feature is really nice, especially because it keeps its state, so I hope this issue can be resolved. (Great work on Zen, I'm promoting it to my friends and in tech forums.)

cimarronline avatar Oct 12 '24 12:10 cimarronline

This issue is also present on Windows 11, 1.0.1-a.9

TheJPMZ avatar Oct 15 '24 11:10 TheJPMZ

Issue also for me. I'd love sidebar to keep it's state so that my video is not interrupted every time I open sidebar with ctrl+p. Device: Windows 11 Enterprise: 22631.4169 Z2n: 1.0.1-a.10 (Firefox 130.0) (64-bit)

Btw: Thanks to Zen staff for modding firefox to the thing I always wanted. Firefox with split view, vertical tabs, and workspaces. This is a dream come true for me.

JanDubcak avatar Oct 16 '24 09:10 JanDubcak

This issue persists in Zen 1.0.1-a.12

Axenide avatar Oct 21 '24 04:10 Axenide

Issue still exists on Zen 1.0.1-a.14.

CrisisModel avatar Oct 28 '24 15:10 CrisisModel

A similar issue came up in the discord where the opening the sidepanel after closing them wouldn't go to the last opened tab but the splash screen.

Disabling this option in the settings fixed it and I would doing that for the time being. Image

However, even if the splash screen was first shown when reopening the sidepanel, the tabs that were previously opened in them retained their state. I was not able to reproduce the following behavior:

every web panel unloads/reloads.

If possible please do provide screen recordings of what you mean so we can look deeper into the issue.

salamijason avatar Oct 30 '24 10:10 salamijason

I attach a screen recording of the issue, which persists on Version 1.0.1-a.14 (64-bit) for Windows 11.

On the recording you will see:

  • Youtube music refreshing when reopening the panel with and without the option "Close the panel..."
  • A timer restarting when reopening the panel

https://github.com/user-attachments/assets/182e218d-1481-49b0-b967-0a8648273e92

TheJPMZ avatar Oct 30 '24 18:10 TheJPMZ

After investigating with the browser debugger, I identified that the page unloads specifically at this line: ZenSidebarManager.mjs#L601.

To confirm, I commented out this line, and the web panel remained loaded as expected.

orswn avatar Oct 31 '24 03:10 orswn

Issue still persists on 1.0.1-a.19

sjclayton avatar Nov 11 '24 05:11 sjclayton

Still an issue on a.22. This is probably the most prominent bug for me personally, the sidebar is such a nice addition but I essentially can't use it without it getting in the way constantly.

XCraftMC23 avatar Dec 02 '24 21:12 XCraftMC23

This seems to be fixed on the Twilight build (thanks!). The side panel is not reloading every time it is toggled. It looks like it's commit 6d41232. So it should be in the next release.

cimarronline avatar Dec 02 '24 21:12 cimarronline

After some further troubleshooting, I've found that it works for me on the regular Twilight build, but not on the AVX2 build. If I remove the avx2 version of twilight and install the normal version, then it works as intended.

I'm on Arch using the builds provided on the AUR, which seem to have the most recent twilight builds. I cannot seem to be able to build zen myself, which is why I am using the AUR versions for troubleshooting.

XCraftMC23 avatar Dec 07 '24 07:12 XCraftMC23

The twilight build is ahead by a bit compared to the alpha build so we should probably wait until the beta release (very soon as of this comment) to see if it's fixed then. Please let me know if you encounter the issue again on the next release.

salamijason avatar Dec 10 '24 12:12 salamijason

I tested Twilight AVX2 and web panels work as intended.

Axenide avatar Dec 10 '24 17:12 Axenide

This is fixed in version 1.0.2-b.0 (64-bit) Windows 11

TheJPMZ avatar Dec 12 '24 05:12 TheJPMZ

Looks like the bug is gone now! Will be closing this issue now but feel free to re-open if you still face the issue. Thanks for your input!

salamijason avatar Dec 15 '24 08:12 salamijason