Pinned tabs revert to normal tabs after window restore, causing browser freeze on close

[lemonteaau]

Preliminary Checks

• [x] I have read and understood the important section above.
• [x] I have searched existing issues and avoided creating duplicates.
• [x] I am not filing an enhancement request.
• [x] I have checked that this issue cannot be reproduced on Mozilla Firefox.
• [x] I have checked that this issue can be reproduced once I removed all my Mods and Custom CSS.

What happened?

After closing a Zen window that contains only pinned tabs using cmd+W (without fully quitting the application) and then reopening it, the previously pinned tabs (Essentials tabs) are rendered as normal, unpinned tabs. Furthermore, attempting to close this restored window again using cmd+W causes the browser to completely freeze/hang. The application becomes unresponsive, and I am forced to force quit and restart Zen to recover.

Expected behavior

When reopening the window, pinned tabs should retain their pinned state. Closing the window a second time should work normally and not cause the application frozen

Actual behavior

Pinned tabs appear as normal tabs upon window restoration. The browser freezes indefinitely when attempting to close the window again with cmd+W.

Steps to reproduce

Open Zen Browser on macOS. Pin one or more tabs. Close any other non-pinned tabs (so only pinned tabs remain). Close the window using the keyboard shortcut Cmd+W (do not Quit the app, just close the window). Reopen the window (e.g., by clicking the Zen icon in the Dock). Observe that the tabs are now rendered as normal tabs (not pinned). Press Cmd+W to close the window again. Observe that the browser becomes unresponsive.

Screenshots and videos

No response

Version

1.17.9b (64-bit)

What platform are you seeing the problem on?

macOS - aarch64

What component is this issue related to?

Tabs

Relevant log output if applicable

[joriswvanrijn]

I experience the same problem! Addition: Merely closing the window and opening it again doesn't solve the issue. Only after manually killing Zen and starting it again, the pins are rendered correctly again and the browser becomes responsive.

Version is as well 1.17.9b, seems to be introduced with this update.

Could this be related?

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWindowMediator.getMostRecentNonPBWindow]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://extensions/content/parent/ext-tabs-base.js :: get topNonPBWindow :: line 1555"  data: no] 3 ext-tabs-base.js:1555:24
    get topNonPBWindow chrome://extensions/content/parent/ext-tabs-base.js:1555
    getTopWindow chrome://extensions/content/parent/ext-tabs-base.js:1568
    getCurrentWindow chrome://extensions/content/parent/ext-tabs-base.js:1596
    getWindow chrome://extensions/content/parent/ext-tabs-base.js:1617
    candidates chrome://extensions/content/parent/ext-tabs-base.js:2263
    next self-hosted:1253
    query chrome://extensions/content/parent/ext-tabs-base.js:2279
    next self-hosted:1253
    query chrome://extensions/content/parent/ext-tabs-base.js:2140
    next self-hosted:1253
    from self-hosted:533
    query chrome://browser/content/parent/ext-tabs.js:1061
    result resource://gre/modules/ExtensionParent.sys.mjs:1223
    withCallContextData resource://gre/modules/ExtensionParent.sys.mjs:666
    result resource://gre/modules/ExtensionParent.sys.mjs:1222
    withPendingBrowser resource://gre/modules/ExtensionParent.sys.mjs:676
    result resource://gre/modules/ExtensionParent.sys.mjs:1221
    callAndLog resource://gre/modules/ExtensionParent.sys.mjs:1172
    recvAPICall resource://gre/modules/ExtensionParent.sys.mjs:1220
    AsyncFunctionNext self-hosted:800
    (Async: async)
    _recv resource://gre/modules/ConduitsChild.sys.mjs:90
    receiveMessage resource://gre/modules/ConduitsParent.sys.mjs:474

[suveshmoza]

I’m experiencing the same issue after updating to v1.17.9b. In my case, the browser freezes right after I close all unpinned tabs. I can still type a URL, but the browser won’t open it, neither by clicking nor pressing enter.

Crash Report https://gist.github.com/suveshmoza/50edcf02fa79490ce84637f9bc8acefa

[cyformatician]

Can confirm, same issue and crash report as @suveshmoza

[myrrhkhan]

Same issue, though on my end, pressing the "x" still works (but not "Cmd + W"). I don't have to quit/force quit the browser, and tabs are restored upon reopening a new window.

[mr-cheffy]

I managed to reproduce it once, but never again. Was it happening on 1.17.8b as well?

[hu-chia]

I managed to reproduce it once, but never again. Was it happening on 1.17.8b as well?

it happens on 1.17.10b at least.

[mr-cheffy]

Please let me know on twilight if it keeps happening!

[suveshmoza]

No browser freeze issue for me on Twilight, @mr-cheffy.

[lemonteaau]

Please let me know on twilight if it keeps happening!

can still be reproduced on twilight 1.18t (64-bit)

https://github.com/user-attachments/assets/a66ea411-087f-4bbd-8254-7f52858ca6aa

[mr-cheffy]

Twilight has seemed to fail due to an outage (https://status.blacksmith.sh/cmihj50z202ma129natooke3e) 😅

Please let me know once this finishes: https://github.com/zen-browser/desktop/actions/runs/19760314163

[mr-cheffy]

Should be up on twilight now, please update and let me know if it happens

[mr-cheffy]

@lemonteaau could you check again if you are free?

[lemonteaau]

@mr-cheffy hi, thanks for the update! I've tested on twilight: Version 1.18t Build ID 20251128113723

Can reproduce only once, after force quit and reopen it can't be reproduced further

[lemonteaau]

already solved in 1.17.11b, thanks for fixing :)