desktop icon indicating copy to clipboard operation
desktop copied to clipboard

pin tab lost

Open youngxhui opened this issue 1 year ago • 9 comments

What happened?

When I pin a tab, close the browser and reopen it, the pinned tab will be lost.

Reproducible?

  • [X] I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.0-a.32

Severity impact

Medium

What platform are you seeing the problem on?

macOS - aarch64

Relevant log output

No response

youngxhui avatar Aug 30 '24 03:08 youngxhui

If it helps... I do find that if i quit using the right click -> quit option on the mac app dock then it loses all pinned tabs, if i quit using cmd+q then they are there when the app is reopened.

Edit - i actually think it is to do with the close button being pressed. It seems when that button is pressed and the app is closed then it will lose the pinned tab

  1. open Zen
  2. Pin a new page
  3. click cmd+q
  4. confirm
  5. reopen zen (the pin should be there)
  6. quit the app using the apple dock but while the browser is still open and showing the pin
  7. reopen zen (the pin should be there)
  8. close the page using the X button on top left
  9. close app from draw using right click and quit
  10. open zen (pinned tab is now gone)

Ashley-Buckingham avatar Sep 08 '24 00:09 Ashley-Buckingham

On the Arch AUR version they are lost regardless of how you close it, either Control + q or using i3 Super + Alt + q, both will not retain pinned tabs.

kylescudder avatar Sep 08 '24 11:09 kylescudder

It does not lose in my case, but it keeps moving the last pinned tab I was on before closing to the top

Muko-Tabi avatar Sep 10 '24 10:09 Muko-Tabi

I also face the same issue as muko-tabi, and I think I also found what is happening, the tabs are getting pinned to the window instead of the profile, so once that window is closed and a new window is opened the pinned tabs are gone. Also on windows the pinned tabs will stay even if you close and reopen the app (if you have enabled the retain previous tabs feature in firefox settings) as long as you don't open a new window, after that firefox keeps track of that window and its tab to reopen upon startup and hence the pinned tabs don't come back. I am on version a-37.

adityapandeydev avatar Sep 10 '24 22:09 adityapandeydev

On Zen 1.0.1-a5 on Windows. Similar problem here - if I open a new Window, the pins are gone.

nsvrana avatar Sep 25 '24 18:09 nsvrana

I have also just experienced this on 1.1-a.7. I think @adityapandeydev is spot on. My issue also arose by opening a new Zen window, which I closed last. I hope this will be fixed soon, as this honestly makes me a bit afraid to spend to much time setting up Zen, when I know, it can all be lost so easily...

ViridityCorn avatar Oct 04 '24 18:10 ViridityCorn

Just thought I would pop in and say I am having this issue as well, on the latest 1.0.1-a.8 (aarch64). Using macOS Sequoia. It doesn't happen all the time, but I can't find a pattern for when it does or doesn't. It more often does reset my pinned tabs, but they do sometimes stick around.

jackgraddon avatar Oct 11 '24 02:10 jackgraddon

This has been bothering me for a long time ... #1350

chlorine3545 avatar Oct 11 '24 04:10 chlorine3545

Right now it is appears that pinned tabs are associated with individual windows. I think the behavior people are looking for is more like what we had in Arc, which is that pinned tabs are more like toolbar favorites where they are permanent across windows, and, even further, they're actually the same instance no matter how many windows you open.

If you select TabA in Window2 and it was already open in Window1, TabA in Window1 becomes inactive, but remains open. If you make changes then select the tab in Windows1, those changes would be reflected there.

This is a core part of the pinned tab concept as implemented elsewhere which is missing from Zen.

nsvrana avatar Oct 11 '24 16:10 nsvrana

I dont have a mac so I can't really see how pinned tabs work in arc, sorry...

Tabs (pinned or not) are window specific, therefor, if you close one window, session restore will just remember the last closed one.

If you could send a video or tutorial that shows how pinned tabs work on arc, I could work something out

mr-cheffy avatar Oct 15 '24 10:10 mr-cheffy

Arc is available on windows as well. Also bookmarks aren't window specific. Arcs pinned tabs work like bookmarks.

adityapandeydev avatar Oct 15 '24 12:10 adityapandeydev

@adityapandeydev The Arc Windows version is so behind the others that it wasn't even exposed to that recent Firebase vulnerability - the exposed functionality hadn't even been implemented yet. Arguably it's not a good representation of the browser today, anyway.

Also chiming in to show support for pinning tabs to spaces, specifically, and not windows. Alternatively, let me put the bookmark bar in the sidebar or something. I just need the top left of the screen to be reliable quick-access to properly daily drive Zen.

hb-robo avatar Nov 11 '24 18:11 hb-robo

Hi, @youngxhui. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • Pinned tabs are not retained after closing and reopening the browser on macOS - aarch64, version 1.0.0-a.32.
  • Multiple users have confirmed the issue across different operating systems and closing methods.
  • The problem may stem from pinned tabs being linked to individual windows rather than profiles.
  • Users are requesting a feature for pinned tabs to act like bookmarks, consistent across all windows.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here.
  • If there is no further activity, I will automatically close this issue in 7 days.

Thank you for your understanding and contribution!

dosubot[bot] avatar Dec 13 '24 16:12 dosubot[bot]

In the latest Version 1.0.2-b.1. The issue seems to be resolved.

adityapandeydev avatar Dec 14 '24 03:12 adityapandeydev

Thank you for your response, @adityapandeydev! We're glad to hear that the issue has been resolved in the latest version. We'll go ahead and close this issue now.

dosubot[bot] avatar Dec 14 '24 03:12 dosubot[bot]