zen-audio-player.github.io
zen-audio-player.github.io copied to clipboard
Provide community favorites shortcut
Motivation and Context
This adds a generalized concept of community favorites, which includes the existing focus shortcut and the new lofi girl shortcut. Closes #374 (Add shortcuts for "community favorites")
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Description
This change adds a shortcut for community favorites as a general concept, clicking it makes appear a shortcut for focus and a shortcut for lofi. Tested it on Safari and Chrome.

Final checklist:
- [X] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [X] I have read the CONTRIBUTING guidelines.
- [X] All tests passed.
Thanks for the PR @naomiceron, pardon my delay in reviewing. Functionality seems solid, mainly two pieces of feedback.
- I think this extra nested layer of the community favorite button can be removed though.
- I noticed there’s a gap here that doesn’t look quite right
Thank you! @shakeelmohamed, should I remove the community button entirely? I ask because of the second point
I noticed there’s a gap here that doesn’t look quite right.
I will make the changes as soon as possible :)
Thank you! @shakeelmohamed, should I remove the community button entirely? I ask because of the second point
Yeah that makes sense to me
@shakeelmohamed Do you still have any interest in having this implemented? I would be happy to work on it if you can think of buttons you would like :)
@jbecker7 Hey welcome! Go for it, please read through all comments in this PR and look at the changes before submitting your own
Closing due to no activity