zen-audio-player.github.io icon indicating copy to clipboard operation
zen-audio-player.github.io copied to clipboard

Provide community favorites shortcut

Open naomiceron opened this issue 3 years ago • 3 comments

Motivation and Context

This adds a generalized concept of community favorites, which includes the existing focus shortcut and the new lofi girl shortcut. Closes #374 (Add shortcuts for "community favorites")

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

This change adds a shortcut for community favorites as a general concept, clicking it makes appear a shortcut for focus and a shortcut for lofi. Tested it on Safari and Chrome. Screen Shot 2021-12-26 at 11 56 36

Final checklist:

  • [X] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [X] I have read the CONTRIBUTING guidelines.
  • [X] All tests passed.

naomiceron avatar Dec 26 '21 19:12 naomiceron

Thanks for the PR @naomiceron, pardon my delay in reviewing. Functionality seems solid, mainly two pieces of feedback.

  1. I think this extra nested layer of the community favorite button can be removed though.
Screen Shot 2022-01-19 at 1 46 13 PM
  1. I noticed there’s a gap here that doesn’t look quite right
Screen Shot 2022-01-19 at 1 45 55 PM

shakeelmohamed avatar Jan 19 '22 21:01 shakeelmohamed

Thank you! @shakeelmohamed, should I remove the community button entirely? I ask because of the second point

I noticed there’s a gap here that doesn’t look quite right.

I will make the changes as soon as possible :)

naomiceron avatar Jan 24 '22 15:01 naomiceron

Thank you! @shakeelmohamed, should I remove the community button entirely? I ask because of the second point

Yeah that makes sense to me

shakeelmohamed avatar Jan 26 '22 18:01 shakeelmohamed

@shakeelmohamed Do you still have any interest in having this implemented? I would be happy to work on it if you can think of buttons you would like :)

jbecker7 avatar Oct 03 '22 03:10 jbecker7

@jbecker7 Hey welcome! Go for it, please read through all comments in this PR and look at the changes before submitting your own

shakeelmohamed avatar Oct 03 '22 05:10 shakeelmohamed

Closing due to no activity

shakeelmohamed avatar Aug 28 '23 09:08 shakeelmohamed