zello-channel-api icon indicating copy to clipboard operation
zello-channel-api copied to clipboard

[JS] End of message lost

Open Skizu opened this issue 3 years ago • 2 comments

When calling outgoingMessage.stop(), stream is stopped before the message has finished being encoded and sent.

Skizu avatar Aug 14 '20 15:08 Skizu

@adambailey- Any solution for this issue?

philliperosario avatar Mar 24 '22 13:03 philliperosario

@philliperosario Fairly recently, I implemented https://github.com/zelloptt/zello-channel-api/pull/172, which adds a Recorder. stopAfter() function. My app uses recorder.js and encoder.js directly, meaning I don't use outgoingMessage.js at all. Since I don't have enough knowledge of how that class works (or the means to test it in a real application), when I implemented that PR above, I did not attempt to have outgoingMessage be modified to include use of new stopAfter function. If you were interested in contributing to the project, and are looking for a quick solution, I'd highly encourage you to throw together a PR. Otherwise, I can circle this back to the Zello team to discuss / prioritize

adambailey- avatar Mar 24 '22 13:03 adambailey-