Zack Elliott
Zack Elliott
The `override` keyword isn't present in the `.d.ts` (https://github.com/microsoft/TypeScript/issues/2000#issuecomment-813527475) and API Extractor runs on `.d.ts`. [Playground](https://www.typescriptlang.org/play?#code/MYGwhgzhAEBCkFNoG8BQ0PQGYHscAoBKALmgDccBLAExQF9UHVRIYBhAC0pFoQA8ALggB21GPAhI0maDjIIATgppJcBEuSq1kDOkA). This should be mentioned in the documentation at https://tsdoc.org/pages/tags/override/. Thoughts @octogonz?
> The behavior makes sense, because the meaning of a custom tag is user-defined. The content may be suitable to render verbatim (``, ``) but maybe not (``, ``). A...
Note that you can define custom TSDoc tags in the `tsdoc.json` file (https://tsdoc.org/pages/packages/tsdoc-config/), if you're not already aware.
This already exists I think - You can turn off `tsdoc-param-tag-missing-hyphen` in your `api-extractor.json` config file. Then you won't get warnings/errors for missing hyphens in `@param` tags. https://github.com/microsoft/tsdoc/blob/e66ec2ca2fe453d53bae9bfe6fc62de7e4c2aef4/tsdoc/src/parser/TSDocMessageId.ts#L161
> However, in this case `aria-controls` for the tab is associated with the tabpanel. `aria-controls` can point to multiple space-separated idrefs (e.g. `aria-controls="foo bar"`), so I don't see this as...
Nice catch @jjaeggli. I agree that this is an issue. I wonder why multi-select tabs use `aria-expanded`... why not use `aria-selected` to indicate multi-selection like other selection widgets?
I haven't looked closely, but I'm guessing that `"api_extractor_defect!FLUX_VALUE:var"` is the _right_ reference. The reference `"api_extractor_defect!FLUX_VALUE"` is generated by the [`DeclarationReferenceGenerator` class](https://github.com/microsoft/rushstack/blob/main/apps/api-extractor/src/generators/DeclarationReferenceGenerator.ts). The missing `:var` piece is called the "meaning"....
Ah - there's https://rushstack.io/pages/contributing/get_started, sorry for not sharing that with you. Is that helpful?
@octogonz I think this is ready for you to take a look!
Haven't taking a super close look yet - but I noticed your `s2-react` package has [some path mappings](https://github.com/antvis/S2/blob/master/packages/s2-react/tsconfig.json) that your `s2-vue` package doesn't have. If you use those same path...