zellij icon indicating copy to clipboard operation
zellij copied to clipboard

Underline colors not working on Window Terminal

Open mmgeorge opened this issue 10 months ago • 4 comments

1. Graphical issue inside a terminal pane (eg. something does not look as it should)

zellij --version: zellij 0.39.2 (I also tried checking out https://github.com/zellij-org/zellij/commit/7f87d93a430a47c82ce3f177a6a2609d3f6abadeand & saw the same thing)

stty size: 56 120

uname -av or ver(Windows): Linux mgeorge 5.15.146.1-microsoft-standard-WSL2 #1 SMP Thu Jan 11 04:09:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Further information

Undercurls are working great, but I seem to be hitting some problems with underline colors in WSL + Window Terminal 1.19/1.20:

echo -e "\x1b[58:5:32m\x1b[4mtest\x1b[59m\x1b[24m" echo -e "\x1b[4:3mTest\x1b[24m "

win-term-default

image

mmgeorge avatar Apr 14 '24 23:04 mmgeorge

How undercurls should be enabled for Zellij in Windows Terminal?

I can see them in Neovim on tmux by a terminal override, but not in Zellij.

Any hint?

steakhutzeee avatar May 06 '24 21:05 steakhutzeee

@steakhutzeee for me they work on the latest version without any additional configuration, just the colors that aren't working for me

mmgeorge avatar May 07 '24 01:05 mmgeorge

With your commands they work for me too. It's in nvim that they are now working. I was able to let them work inside tmux but not outside with a terminal override. Any idea how to do this with Zellij?

steakhutzeee avatar May 07 '24 07:05 steakhutzeee

Sorry @steakhutzeee I'm not sure what would be causing them to work in tmux but not zellij. On my end at least they just work by default with the latest zellij.

mmgeorge avatar May 08 '24 00:05 mmgeorge

Can confirm, works well under WinTerm (after using the tweak below), but not under WinTerm + Zellij.

I had to execute the following line to make the colored underline work (added it to my ~/.zshrc for convenience)

$ set -as terminal-overrides ',*:Setulc=\E[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m'´

Src: https://github.com/helix-editor/helix/issues/7065#issuecomment-1740422472

However this does not fix the colored underlines when using Zellij via WinTerm

achkasov avatar May 09 '24 17:05 achkasov

Can confirm, works well under WinTerm (after using the tweak below), but not under WinTerm + Zellij.

I had to execute the following line to make the colored underline work (added it to my ~/.zshrc for convenience)

$ set -as terminal-overrides ',*:Setulc=\E[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m'´

Src: helix-editor/helix#7065 (comment)

However this does not fix the colored underlines when using Zellij via WinTerm

This should be tmux config, not zsh. Correct?

steakhutzeee avatar May 10 '24 12:05 steakhutzeee