zellij icon indicating copy to clipboard operation
zellij copied to clipboard

update the pane name when editing a buffer

Open cosminadrianpopescu opened this issue 2 years ago • 6 comments

This pull request should update the pane editing a buffer.

cosminadrianpopescu avatar Jun 10 '22 18:06 cosminadrianpopescu

@imsnif This is the original commit for the PR. There is one small issue: when editing the pane the title is update accordingly. But when closing the editor, the title does not get updated. It needs a refresh. For example, if I switch to another tab and back, the title is update back to "Pane #1". Any ideas?

cosminadrianpopescu avatar Jun 10 '22 18:06 cosminadrianpopescu

I see also a test failing. I will fix it.

cosminadrianpopescu avatar Jun 10 '22 18:06 cosminadrianpopescu

@imsnif So, I see that the tests are failing because of the title being different. Can you please explain me how the snapshot assertion is working?

cosminadrianpopescu avatar Jun 10 '22 20:06 cosminadrianpopescu

Hey, @cosminadrianpopescu I'm sorry for not responding but I'm going on vacation and don't have a lot of time. I'll be back around June 24th and can reply in more detail then. Until then, there's some information about the tests in CONTRIBUTING.md - we generally use snapshot tests created with cargo insta.

imsnif avatar Jun 12 '22 16:06 imsnif

Hello @imsnif and the others. I'm back from holidays and I will start working again on zellij. Meanwhile I will open a bug report.

cosminadrianpopescu avatar Aug 01 '22 07:08 cosminadrianpopescu

Hey, what's the status of this?

imsnif avatar Sep 09 '22 07:09 imsnif

Already implemented

imsnif avatar Feb 20 '23 16:02 imsnif