zeldaret
Document `PLAYER_STATE1_SHIELDING`
Think I would prefer PLAYER_STATE1_USING_SHIELD to mirror PLAYER_STATE1_USING_BOOMERANG and PLAYER_STATE2_USING_OCARINA (https://github.com/zeldaret/oot/pull/2277)
Also want to note I have already started documenting shield related Upper Actions and Main actions. We keep seeming to overlap what we are working on 😅
I can change it to PLAYER_STATE1_USING_SHIELD or close the PR and just let you do it with the actions, I don't mind either way.
We keep seeming to overlap what we are working on 😅
There's not many easy flags to document left so it's bound to happen 🙃
Since the flag gets set in so many places I would personally prefer to get those functions documented first. But this name is probably accurate and could be named early, so I dont really mind either way
Now that I think about it, PLAYER_STATE1_USING_SHIELD isn't really accurate since the flag also gets set if you use the giant's knife/bgs to block.
Well then "shielding" isnt really either haha. That state is kinda strange anyway, it doesnt even have a collider so it doesnt block anything. Its pretty useless. I think its fair to say that using shield results in this special case behavior when you have a two handed weapon.
But anyway this kind of stuff would be easier to read if the surrounding functions were documented, so maybe we do wait
The original animation names call it "defending", but I dont think any of these work for two handed which isnt blocking guarding or defending anything.
Im fine with just going with shielding for now though.