Rename `ANIM_FLAG_NO_MOVE` to `ANIM_FLAG_ADJUST_STARTING_POS`
I have been staring at this flag for weeks.
Something seemed off about this flag to me when you would see usages like (ANIM_FLAG_PLAYER_SETMOVE | ANIM_FLAG_NO_MOVE) in Player code.
The flag really disables movement for one frame. And the way player uses it, it disables movement for the first frame of a new animation when it begins playing. This allows the transition from one animation to another to be more smooth, without subtle position warping. Its pretty complicated and only relevant in some cases. See the very large description above the flag in the PR for more details.
Open to suggestions on how to clear up the explanation, or how to trim it down so it isn't so long.
-- Here is a video example of what happens if you dont use this flag when you're supposed to. Note the subtle shifts in Links position on some of the animation changes: https://youtu.be/-hJA53d8BPI
Here are screenshots of logs that show the translation data and world position in the above scenario. Specifically, the few frames around when link sits up (about 0:35 in the video). The translation data is in model space, so its a bit confusing to read. But you can see the translation data for frame 1 of the new animation, and you can see it get applied in the case where the flag is disabled.
Thanks to tharo for letting me ramble about this flag when I was confused, and for helping me figure out some things.
The animations do actually flow properly. The location where the "sits up" animation ends is at exactly the same point where "sits idly" begins.
The problem is that in Player_AnimReplaceApplyFlags, it will reset prevTransl to the "origin". This is good if both animations that are chained together begin at the "origin". They would flow properly in this case. But because it doesn't do that, this is a workaround for that specific scenario. I do think the fix to this problem could have happened elsewhere, this feels pretty hacky to me.
The very long explanation on the flag tries to explain this, but I know its alot to take in.