oot icon indicating copy to clipboard operation
oot copied to clipboard

[Doc] actor En_Dodojr (Baby Dodongo)

Open krm01 opened this issue 3 years ago • 3 comments

The organization of this actor is... interesting. It was very difficult for me to settle on decent names, and there's a lot I am still unhappy about, but hopefully things are clear enough to understand at least and get the discussion started.

Also, I learned play->actorCtx.unk_02 is some kind of "hammer shockwave timer", that gets set when the player's hammer strikes the ground and decreases every frame therafter back to 0. I didn't name that to keep the scope small, but wanted to write it down somewhere for the future.

edit: Oh also, I added prototypes for all functions that were missing one. I feel like I see some actors doing this and others not - personally, I like it a lot. But if that's not consistent with style preferences let me know and I can remove it.

krm01 avatar Jun 30 '22 03:06 krm01

re the last point, yeah we only have forward declarations for functions when they are necessary (meaning its referenced before the definition in the file)

This should be pretty consistent across all files since it was enforced during the decomp review process, but if some have unnecessary declarations then they should be removed

fig02 avatar Jun 30 '22 04:06 fig02

@fig02 agree, it's a weird one. I think you're right that UpdateBounces is better at least, changed to that.

krm01 avatar Jul 28 '22 01:07 krm01

Looks good to me overall, I simply commented on a couple existing comments

Roman971 avatar Jul 29 '22 21:07 Roman971