oot
oot copied to clipboard
zeldaret
Document En_Ko Animations
To get this moving again, I think the main thing holding it up is the prefix discussion above. I would just prefix it as Kokiri without the "boy" "girl" or "Fado" etc. At least all of the ones that are compatible with each other.
Also as a side note, force pushing makes it harder to track the git history over time as we do reviews. So if you could just do normal pushes that would make things easier
Yeah I can fix those prefixes.
Was force pushing because I was amending my commits, trying to keep the overall hit history clean so that new documentation can be self-contained in the event that someone has an issue with it. Can do multiple commits if that’s what the consensus is though.
On Sat, Aug 27, 2022 at 10:17 AM fig02 @.***> wrote:
To get this moving again, I think the main thing holding it up is the prefix discussion above. I would just prefix it as Kokiri without the "boy" "girl" or "Fado" etc. At least all of the ones that are compatible with each other.
Also as a side note, force pushing makes it harder to track the git history over time as we do reviews. So if you could just do normal pushes that would make things easier
— Reply to this email directly, view it on GitHub https://github.com/zeldaret/oot/pull/1306#issuecomment-1229211660, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDDM35JNIKDDOYQKIKGREDV3IWR7ANCNFSM5Z42BXBA . You are receiving this because you authored the thread.Message ID: @.***>
We squash merge commits anyway, so no matter what your commit history looks like it will be committed to master as 1 commit. The intermittent commits before that point just make it easier to review and dont mess with the github review comment history
Ahhh gotcha, didn’t realize that
On Sat, Aug 27, 2022 at 10:38 AM fig02 @.***> wrote:
We squash merge commits anyway, so no matter what your commit history looks like it will be committed to master as 1 commit. The intermittent commits before that point just make it easier to review and dont mess with the github review comment history
— Reply to this email directly, view it on GitHub https://github.com/zeldaret/oot/pull/1306#issuecomment-1229214905, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDDM37RWH5YP6F722UPXU3V3IZARANCNFSM5Z42BXBA . You are receiving this because you authored the thread.Message ID: @.***>
Removed BOY, GIRL, and FADO. Was considering removing KNOWITALL as well but those are just the standard BOY models so I'm not sure it's in the same category. What do y'all think?
Sorry, will get on this soon 😅
On Mon, Oct 10, 2022 at 12:45 AM Dragorn421 @.***> wrote:
@.**** commented on this pull request.
@CharlesAverill https://github.com/CharlesAverill (bump) ENKO_ANIM_KNOWITALL_ can go
Also I think when we said to not use boy/girl/fado/... prefixes it wasn't just for the ENKO_ANIM_ enum but also the symbols like gKokiriFadoIdleAnim -> gKokiriIdleAnim, but I'd like confirmation, @fig02 https://github.com/fig02 ?
— Reply to this email directly, view it on GitHub https://github.com/zeldaret/oot/pull/1306#pullrequestreview-1135497549, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALDDM36L346PCA7IN5I7NP3WCOUQJANCNFSM5Z42BXBA . You are receiving this because you were mentioned.Message ID: @.***>
yea, they can be removed from the anim names as well since they care compatible with all the kokiri skeletons