mm icon indicating copy to clipboard operation
mm copied to clipboard

General Cleanup 11

Open hensldm opened this issue 3 years ago • 3 comments

I should be getting close to done with these for the time being :) . Does 5 things:

  1. Changes char to UNK_TYPE1 for decomped actors with struct padding
  2. Fixes a couple usages of SubS functions
  3. Uses the EXCHANGE_ITEMs as the last arg to func_800B8500
  4. Cleans up some actor macros
  5. A few misc stuff I saw

hensldm avatar Jul 27 '22 06:07 hensldm

While you are swapping around my old GET_ACTOR_PARAM macros back to ACTOR_GET_PARAM, EnKakasi also should be fixed.

isghj5 avatar Jul 27 '22 06:07 isghj5

Is char -> UNK_TYPE1 something that has been discussed for MM?

For OoT iirc last time we talked about these UNK_ types the consensus seemed to be "we won't ever know what these are/were so char is okay as a placeholder"

Dragorn421 avatar Jul 27 '22 14:07 Dragorn421

Yes we have been using UNK_TYPE1 as a placeholder instead of char

AngheloAlf avatar Jul 27 '22 15:07 AngheloAlf