mm
mm copied to clipboard
zeldaret
Remove global dependencies (1)
One thing of note: a pair of actor headers written in a way that made them dependent on GreatFairyType enum z_bg_dy_yoseizo.h. I rewrote them to not require this dependency because z_bg_dy_yoseizo.h itself imports the dependency of object_dy_obj.h, which isn't really valid for either actor.
There are some parts of this PR that still need a bit more discussion, but I think the new z_en_a_obj.h and z_en_item00.h headers are good to have. What do you think about moving them to a new PR? We can probably get them merged them sooner.
About the current PR, as you have probably noted there are still a few stuff that haven't been moved to a better place and stuff still depend on global.h.
I think it would be easier to do cleanup in other headers and get rid of other stuff, like, for example, getting rid of functions.h and variables.h
There are some parts of this PR that still need a bit more discussion, but I think the new
z_en_a_obj.handz_en_item00.hheaders are good to have. What do you think about moving them to a new PR? We can probably get them merged them sooner.
I would agree with the sentiment. It would be nice to separate those two headers into there own PR.
