mm icon indicating copy to clipboard operation
mm copied to clipboard

Explicitly extract room DLs that ZAPD can't detect

Open tom-overton opened this issue 7 months ago • 0 comments

There was a discussion in the discord where we discussed how for certain rooms, not all of their displaylists were being extracted. I did some more digging, and it turns out that this applies for almost every room in the game. We're missing out on hundreds of DLs because these DLs are not referenced by anything, so I don't think ZAPD is even aware of their existence.

This PR manually extracts all of these missing room DLs by updating the various scene XMLs. I wrote a script to detect unextracted DLs in the unaccounted sections of a room's C file, so I'm fairly sure I got all of them. These DLs actually comprise a massive chunk of the unaccounted bytes in our repo, so it seemed worthwhile to do.

Before: image

After: image

tom-overton avatar Jul 01 '24 07:07 tom-overton