mm
mm copied to clipboard
More header cleanup
- Move many function declarations (and some variables) into new or existing headers.
z64kanfont.his a notable one since it also movesFontand a few defines fromz64message.hz64path.hmovesPathfromz64scene.h- Move
gPlayerFormObjectIdstoz64player.h: It originally belongs toobject_table.c, but I feel it makes more sense in the player header.
- Move the actor and object segment declaration out of
segment_symbols.hand only use them in the places they are used.- This introduces a
z64actor_dlftbls.hheader, putting the related declarations there.
- This introduces a
- ~~Introduce
ObjectOverlayforgObjectTable.~~- ~~I don't think it is correct to use
RomFilehere even if it is the same struct, since they represent different data (objects vs rooms)~~
- ~~I don't think it is correct to use
I don't think it is correct to use RomFile here even if it is the same struct, since they represent different data (objects vs rooms)
Are you confusing Rom and Room?
OoT has this in z64dma cause it represents a generic file that gets dma'd from ROM, its not only for rooms
No. I do think it is better for those two struct to be different, even if they look the same. It is used in only two places, as a list of rooms in a scene and in the object table, and I couldn't find any code that needs them to be the same
Its just a generic struct that has a rom start and end. What the contents of the file is doesnt really matter. I dont agree it needs to be different. Also, it gets used in kankyo too for skybox files.
Also, objects are not overlays. So even if it did use a different struct, it would need a different name. But I dont think it needs a new struct
(resolved in discord)