mm icon indicating copy to clipboard operation
mm copied to clipboard

z_collision_check_OK

Open RevoSucks opened this issue 2 years ago • 6 comments

I had to use a weird struct for one TriNorm, because 3 separate symbols kept being reordered, and the 2nd one was an extra +8 for some reason. I have no clue what IDO put there, so I kinda cludged it for now.

I also moved prevent_bss_reordering lower to make the first part of BSS correct. Its a workaround, but the file is correct now, well, maybe.

Feel free to suggest a better match.

RevoSucks avatar Nov 10 '23 05:11 RevoSucks

Whoops, 2 variables slipped into tools/variables.txt.

RevoSucks avatar Nov 10 '23 05:11 RevoSucks

Hold on, something broke. It was OK earlier.

RevoSucks avatar Nov 10 '23 05:11 RevoSucks

I fixed the weird struct. It was not needed after all.

RevoSucks avatar Nov 10 '23 05:11 RevoSucks

fyi we have been avoiding this file because of how much bss it has. Header changes can affect very aggressively to the bss reorder, specially in in-function-static bss. We have been waiting to have the headers a bit more splitted before tackling this one, so we can not include global.h and have finer control over the included stuff. Due to all of this, this PR will be in "held" hell for a long while, like #1450 is

AngheloAlf avatar Nov 10 '23 12:11 AngheloAlf

I will periodically update it, yes.

RevoSucks avatar Nov 20 '23 20:11 RevoSucks

Would you like help updating this PR? Still would like to see it go through some more merges, but would be good to see it updated to see how bss treats us.

hensldm avatar May 14 '24 03:05 hensldm