mm
mm copied to clipboard
zeldaret
Rename `PlayerAgeProperties`
The PlayerAgeProperties name is a holdover from the OoT decomp project because it is used for the two ages in OoT, but it is used for each transformation (and Kafei) in MM.
It would be nice if we could rename it to something that better reflects what it represents in MM. We should also consider if we want to keep the name synced with OoT.
Currently there are two possible options:
-
PlayerTransformationProperties -
PlayerFormProperties
I would prefer a name that both could use, and this Sakurai video makes me want to have it named PlayerParameters, or drop Age from the OoT name
Would this be as simple as a refactor of the name or would it require a bit more work?
Actually doing it would be just a refactor, the tricky part is actually deciding on a new name
I suppose some people would prefer it stay the same just for authenticity or something? I can't think of an exact reason but some people might prefer it stay the same for consistency or something like that, to keep engine differences minimal from OOT I suppose. I think it'd make sense to be changed but also I'm not sure if it should stay the same.
I think PlayerFormProperties would be a good name if it did get refactored though
What do you think about this @AngheloAlf? Would it be better off staying the same to keep consistent, or should it be changed? I'm still a bit mixed on it and want a definitive opinion from someone.
It is tempting, yes. The main issue is discussing with the rest of the contributors to decide and agree in a new name. Since you seem to be really interested in this I suggest you to join our discord server where we have most of our discussions https://discord.zelda64.dev/
Yeah, I'm still learning C and programming in general, but I'd love to contribute in some way :)