botw
botw copied to clipboard
most of AirOctaFlyUp is done, some of AirOctaDataMgr is done
I've decompiled AirOctaFlyUp functions handleMessage_, enter_, and leave_, and calc, which is nearly complete but still has 2 instructions that are different. I've also decompiled the AirOctaDataMgr function sub_71002fb17c (to be named), which is in /game right now because i dont know where the proper location for it would be.
ok, ive fixed all the issues that i understand how to. There's also some changes that arent related to airoctaflyup, because ive also been working on airoctareaction and that relys on functions in some of the same files as airoctaflyup.
i cant do the one for moving the airoctadatamgr include to the cpp because it needs to be there for the airoctadatamgr** data_mgr class variable and i cant do the one about removing the damagemgr include because then it cant call any of its functions, but besides those I think everything's done.
So sorry for the delay - I'll take a look at the latest changes this weekend (and hopefully this can be merged then)
ok the naming issues should be all fixed, i got damagemgrbase forward declared and just removed getdamagemgrderived because getDamageMgr does the exact same thing and it isnt actually being used in airoctaflyup
ok i actually uploaded actactor.h this time :P. I got all of the other comments done, but ive not made fly_up_cycles being *.5 in the multiplier variable bc that leads to it diffing a lot more. Also, ive chosen to name min fly_up_turning_pts- if its a physical cycle like a sine wave it's going to have (2x the number of cycles -1) of peaks and troughs.
It seems the linter is unhappy about some of the formatting - could you run clang-format on the files it's complaining about? lgtm other than that
done!!