Vìncent Le Goff

Results 95 comments of Vìncent Le Goff

> approved but holding for 3.1 release Should i also port this to 2.X ?

> I think we can have this as an option. > Would you like to send a Pull Request to address this issue? Remember to add unit tests. How would...

It's an old one, but was stalling in one of my repositories. But in this project i don't use any feature involving the need of fastify-static that's why I'm bringing...

This is a good analysis of the current situation. A good roadmap would be to migrate to `@fastify` scope and refactor it afterward?

No quite the same example but i made it work using this api spec: https://github.com/keycap-archivist/app/blob/master/src/assets/v2-spec.yaml#L81-L99 using this configuration: https://github.com/keycap-archivist/app/blob/master/src/app.ts#L39 @xplodeart can you test those specs?

> @zekth what about a dynamic example? Unfortunately `requestBody` doesn't seem to be allowed when setting a inline schema in app.ts (not an external file like you do). `requestBody` is...

@climba03003 do we really need to pass the `validateWebSocket` as an option to override the `WebSocket` one? If there a specific reason to not do it inside `fastify-websocket`? Other your...

> Could you emit an event in case a packet is dropped? In a case of `strictMode` set to `false`? Yes sure

> that a user wants to validate every message I don't get why some people would want to validate only a subset of messages > that a developer wants to...

> Lots of wire protocols have modes where they flip from some structured message format to a binary stream for a while, like Postgres' COPY instruction https://github.com/fastify/fastify-websocket/pull/191/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R218 > narrow set...