DrRandom comments

Results 185 comments of


                                            DrRandom

Allow user to pass partition label to the handleUpdate method of the HTTPUpdate class.

Well, it was already a bad design from the start. If we can create multiple partitions why can't we update them individually from the start? I mean, the option is...

Allow user to pass partition label to the handleUpdate method of the HTTPUpdate class.

Ah it cant. With each update it downloads both files at once from a server :D

Allow user to pass partition label to the handleUpdate method of the HTTPUpdate class.

Each version comes with a backend and a frontend.

Allow user to pass partition label to the handleUpdate method of the HTTPUpdate class.

That would be nice

Allow user to pass partition label to the handleUpdate method of the HTTPUpdate class.

That way we dont have to modify the existing functions

Allow user to pass partition label to the handleUpdate method of the HTTPUpdate class.

It isnt even spiffs anymore so

Allow user to pass partition label to the handleUpdate method of the HTTPUpdate class.

I had to specify the label at two different places in order to work. Will check on it tomorrow

Allow user to pass partition label to the handleUpdate method of the HTTPUpdate class.

`updateSpiffs(WiFiClient& client, const String& url, const String& currentVersion, HTTPUpdateRequestCB requestCB)` calls `handleUpdate(HTTPClient& http, const String& currentVersion, bool spiffs, HTTPUpdateRequestCB requestCB)` which then calls `runUpdate(Stream& in, uint32_t size, String md5, int...

Allow user to pass partition label to the handleUpdate method of the HTTPUpdate class.

If we create a new function like `update(HTTPClient& http,const char* partitionLabel,HTTPUpdateRequestCB requestCB)` we still need to call `handleUpdate` and `runUpdate` ?!

Allow user to pass partition label to the handleUpdate method of the HTTPUpdate class.

What i can see here is that we must modify the handleUpdate and runUpdate methods like this ```cpp t_httpUpdate_return handleUpdate(HTTPClient& http, const String& currentVersion, bool spiffs = false, const char*...