Gregor Zeitlinger

Results 83 comments of Gregor Zeitlinger

@jack-berg added all suggested changes - and even figured out how to appease jCmpApi (hopefully correctly).

An additional SPI is needed for `ConfigProperties` - this is needed to create an adapter for spring properties: https://github.com/zeitlinger/opentelemetry-java/blob/c1534b5513b29c6ce6b8020bbf05a5bead68e5a2/sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java#L571-L585

> An additional SPI is needed for `ConfigProperties` - this is needed to create an adapter for spring properties: https://github.com/zeitlinger/opentelemetry-java/blob/c1534b5513b29c6ce6b8020bbf05a5bead68e5a2/sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkBuilder.java#L571-L585 sorry, just saw that there is already `setConfig`

Thanks @jack-berg for getting it into this release :tada:

@jack-berg here's my attempt based on our conversation yesterday. Here's what you proposed: ```java String result = Baggage.fromMap(Map.of("key", "value")) .storeInContext(Context.current()) .wrap(() -> "result") .call(); ``` This is what I find...

Here's a page that has a working example for configuring samplers for the spring starter: https://opentelemetry.io/docs/languages/java/automatic/spring-boot/#exclude-actuator-endpoints-from-tracing I'd suggest to make links both ways.

> I'm unsure about how to proceed with this pull request. > > Any guidance would be greatly appreciated! 😄 I would go ahead with this PR. It's true that...

> otel.instrumentation.optional.resource.providers I think this is a good idea :smile: - why use a FQN here instead of the short names as for other providers? - I'd also like to...

Sorry, confused that with exporter...