zeitgeist icon indicating copy to clipboard operation
zeitgeist copied to clipboard

Add integration tests for RPC calls and runtime configuration

Open maltekliemann opened this issue 2 years ago • 5 comments

We've had some RPC calls fail due to incorrect order of arguments and encoding problems, which can't easily be caught. Writing some integration tests might help here.

Also, @vivekvpandya pointed out that it might be a good idea to test the runtime configuration. For example, do the thresholds we define for the Advisory Committee really do what we think they do?

maltekliemann avatar Feb 22 '23 10:02 maltekliemann

@vivekvpandya Actually, wouldn't it be easier to write tests for the runtime configuration in runtime/?

maltekliemann avatar Feb 22 '23 11:02 maltekliemann

@vivekvpandya Actually, wouldn't it be easier to write tests for the runtime configuration in runtime/? Yes I agree with you.

vivekvpandya avatar Feb 22 '23 11:02 vivekvpandya

MVP of integration tests should contain the following:

  • Local node produces blocks and accepts transactions.
  • Call filters work as expected.

I'd describe the long-term vision as follows: Our "unit" tests just use the other pallets as mocks, so they're basically integration tests. We may want to design our units tests to use actual mocks and move integration tests into runtime.

maltekliemann avatar Sep 27 '23 12:09 maltekliemann

Local node produces blocks and accepts transactions.

This is planned to be part of the release automation CI https://github.com/zeitgeistpm/zeitgeist/issues/870

sea212 avatar Sep 28 '23 09:09 sea212

Moving to next milestone because no one is assigned.

maltekliemann avatar Feb 07 '24 22:02 maltekliemann